RESOLVED FIXED 83762
[Chromium] Add WebKit API to access <datalist> options 
https://bugs.webkit.org/show_bug.cgi?id=83762
Summary [Chromium] Add WebKit API to access <datalist> options
Keishi Hattori
Reported 2012-04-12 02:15:57 PDT
Introduce WebDataListElement and expose HTMLDataListElement to chromium.
Attachments
Patch (13.82 KB, patch)
2012-04-12 04:50 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (13.83 KB, patch)
2012-04-12 05:24 PDT, Keishi Hattori 		tkent: review-
DetailsFormatted DiffDiff
Reverted indentation fix (8.53 KB, patch)
2012-04-12 06:56 PDT, Keishi Hattori 		tkent: review-
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Used WebInputElement::dataListOptions (3.25 KB, patch)
2012-04-13 01:04 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-04-12 04:50:43 PDT
Created attachment 136877 [details] Patch
WebKit Review Bot
Comment 2 2012-04-12 04:54:20 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Keishi Hattori
Comment 3 2012-04-12 05:24:13 PDT
Created attachment 136882 [details] Patch
Kent Tamura
Comment 4 2012-04-12 06:34:20 PDT
Comment on attachment 136882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review r- because of unrelated indentation fix. > Source/WebKit/chromium/ChangeLog:14 > + * public/WebInputElement.h: Fix indentation. Please do not fix indentation in this patch. > Source/WebKit/chromium/public/WebInputElement.h:90 > + WEBKIT_EXPORT WebDataListElement dataList() const; > + We won't need WebDataListElement if we introduce just "WebNodeCollection dataListOptions()" to WebInputElement. What do you think?
Keishi Hattori
Comment 5 2012-04-12 06:50:14 PDT
Comment on attachment 136882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review >> Source/WebKit/chromium/public/WebInputElement.h:90 >> + > > We won't need WebDataListElement if we introduce just "WebNodeCollection dataListOptions()" to WebInputElement. What do you think? Do we add HTMLInputElement::dataListOptions()? or are we allowed to implement it in WebInputElement.cpp?
Keishi Hattori
Comment 6 2012-04-12 06:56:09 PDT
Created attachment 136898 [details] Reverted indentation fix
WebKit Review Bot
Comment 7 2012-04-12 07:52:19 PDT
Comment on attachment 136898 [details] Reverted indentation fix Attachment 136898 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12392425
Kent Tamura
Comment 8 2012-04-12 18:26:00 PDT
(In reply to comment #5) > Do we add HTMLInputElement::dataListOptions()? or are we allowed to implement it in WebInputElement.cpp? The latter is ok.
Kent Tamura
Comment 9 2012-04-12 18:27:23 PDT
Comment on attachment 136898 [details] Reverted indentation fix r- because of a build failure
Keishi Hattori
Comment 10 2012-04-13 01:04:30 PDT
Created attachment 137055 [details] Used WebInputElement::dataListOptions
WebKit Review Bot
Comment 11 2012-04-13 01:07:12 PDT
Attachment 137055 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebInputElement.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 12 2012-04-13 01:11:35 PDT
Comment on attachment 137055 [details] Used WebInputElement::dataListOptions Looks reasonable.
WebKit Review Bot
Comment 13 2012-04-13 04:09:49 PDT
Comment on attachment 137055 [details] Used WebInputElement::dataListOptions Clearing flags on attachment: 137055 Committed r114108: <http://trac.webkit.org/changeset/114108>
WebKit Review Bot
Comment 14 2012-04-13 04:09:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.