WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83742
Implement DataList UI for chromium
https://bugs.webkit.org/show_bug.cgi?id=83742
Summary
Implement DataList UI for chromium
Keishi Hattori
Reported
Thursday, April 12, 2012 4:03:18 AM UTC
Show datalist suggestions in a popup
Attachments
Patch
(24.19 KB, patch)
2012-04-11 21:46 PDT
,
Keishi Hattori
tkent
: review-
Details
Formatted Diff
Diff
Patch
(29.16 KB, patch)
2012-04-12 01:29 PDT
,
Keishi Hattori
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Reverted indentation fix
(8.53 KB, patch)
2012-04-12 06:54 PDT
,
Keishi Hattori
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Keishi Hattori
Comment 1
Thursday, April 12, 2012 5:46:43 AM UTC
Created
attachment 136823
[details]
Patch
Keishi Hattori
Comment 2
Thursday, April 12, 2012 5:47:54 AM UTC
isherman@ reviewed it
http://codereview.chromium.org/10037002/
chromium part is here
http://codereview.chromium.org/10024059/
WebKit Review Bot
Comment 3
Thursday, April 12, 2012 9:22:50 AM UTC
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 4
Thursday, April 12, 2012 9:23:12 AM UTC
Attachment 136823
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp:102: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/WebInputElement.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/public/WebInputElement.h:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keishi Hattori
Comment 5
Thursday, April 12, 2012 9:26:05 AM UTC
Oops, I uploaded an old patch. I will upload a new one.
Kent Tamura
Comment 6
Thursday, April 12, 2012 9:28:06 AM UTC
Comment on
attachment 136823
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=136823&action=review
> Source/WebKit/chromium/ChangeLog:8 > + Implement DataList UI for chromium > +
https://bugs.webkit.org/show_bug.cgi?id=83742
> + > + Expose HTMLDataListElement in the WebKitAPI. > + Introduce MenuItemIDs. > +
This patch doesn't implement the UI, do it? The summary looks not concrete. I think adding WebDataListElement and the autofill-related changes should be separated patches. Also, you should explain why you'd like to make these changes in ChangeLog.
> Source/WebKit/chromium/public/WebAutofillClient.h:36 > +enum {
This should be put inside of WebAutofillClient class.
> Source/WebKit/chromium/public/WebAutofillClient.h:62 > - int uniqueID, > + int itemID,
You have to update the explanation of uniqueID in the comment.
> Source/WebKit/chromium/public/WebDataListElement.h:44 > +// Provides readonly access to some properties of a DOM input element node.
input -> datalist
Keishi Hattori
Comment 7
Thursday, April 12, 2012 9:29:56 AM UTC
Created
attachment 136849
[details]
Patch
WebKit Review Bot
Comment 8
Thursday, April 12, 2012 9:54:49 AM UTC
Comment on
attachment 136849
[details]
Patch
Attachment 136849
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/12387587
Keishi Hattori
Comment 9
Thursday, April 12, 2012 2:54:30 PM UTC
Created
attachment 136897
[details]
Reverted indentation fix
darby.webkit
Comment 10
Sunday, May 6, 2012 6:09:41 PM UTC
Complete newbie to webkit bugzilla here, so I hope I'm not committing any transgressions. Thanks so much for all your work on this. Just wanted to point out that this doesn't seem to be working for input elements with the 'email' type (but does for those with 'tel', 'url', or 'search').
Keishi Hattori
Comment 11
Monday, May 7, 2012 1:24:26 AM UTC
(In reply to
comment #10
)
> Complete newbie to webkit bugzilla here, so I hope I'm not committing any transgressions. Thanks so much for all your work on this. Just wanted to point out that this doesn't seem to be working for input elements with the 'email' type (but does for those with 'tel', 'url', or 'search').
Thanks! Datalist for email type is disabled intensionally because we are still working on it.
https://bugs.webkit.org/show_bug.cgi?id=84346
darby.webkit
Comment 12
Monday, May 7, 2012 4:04:48 AM UTC
(In reply to
comment #11
)
> (In reply to
comment #10
) > > Complete newbie to webkit bugzilla here, so I hope I'm not committing any transgressions. Thanks so much for all your work on this. Just wanted to point out that this doesn't seem to be working for input elements with the 'email' type (but does for those with 'tel', 'url', or 'search'). > > Thanks! Datalist for email type is disabled intensionally because we are still working on it. >
https://bugs.webkit.org/show_bug.cgi?id=84346
Ah, apologies for missing that. Thanks!
Kent Tamura
Comment 13
Thursday, March 28, 2013 9:27:28 AM UTC
done
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug