WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6999
Dynamically added link-tag disables the use of change styles dynamically
https://bugs.webkit.org/show_bug.cgi?id=6999
Summary
Dynamically added link-tag disables the use of change styles dynamically
Sjoerd Mulder
Reported
2006-02-01 01:56:06 PST
If you dynamicly add a link-tag to the head, and after this change for example the href value of this link tag. Safari constantly seems to redraw elements which are change by changing a .style. propery through testcase. For more info see attached testcase
Attachments
Testcase
(2.16 KB, text/html)
2006-02-01 01:56 PST
,
Sjoerd Mulder
no flags
Details
patch
(1.34 KB, patch)
2006-03-16 20:08 PST
,
Alice Liu
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sjoerd Mulder
Comment 1
2006-02-01 01:56:38 PST
Created
attachment 6178
[details]
Testcase
David Kilzer (:ddkilzer)
Comment 2
2006-02-01 04:36:09 PST
Confirmed bug. Added HasReduction keyword.
Sjoerd Mulder
Comment 3
2006-02-03 00:39:36 PST
This bug is also in Radar: <
rdar://4432162
>
Alice Liu
Comment 4
2006-03-13 19:23:29 PST
I tried a test case where the link tag wasn't a style sheet but just an href with the href being updated after appendChild and the flickering isn't observed. Looks like it needs to be a style sheet, but I haven't tried other types of link tags besides that one.
Alice Liu
Comment 5
2006-03-16 20:08:54 PST
Created
attachment 7122
[details]
patch uploading patch
Alice Liu
Comment 6
2006-03-16 20:23:51 PST
hmm, i dont know if i chose the right settings when i uploaded the patch.
Dave Hyatt
Comment 7
2006-03-17 00:36:35 PST
Comment on
attachment 7122
[details]
patch Looks good. One minor style quibble... we leave braces off single-line if statements, so: + if (m_loading) { + getDocument()->stylesheetLoaded(); + } should lose the braces. r=me
David Kilzer (:ddkilzer)
Comment 8
2006-03-17 05:38:12 PST
(In reply to
comment #7
)
> r=me
Doesn't this patch need a LayoutTest, or can this not be tested automatically?
David Kilzer (:ddkilzer)
Comment 9
2006-03-18 03:22:28 PST
This patch was applied as
r13371
. Updating state to RESOLVED FIXED.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug