RESOLVED FIXED 48693
Add idl and mock classes for FileWriterSync. 
https://bugs.webkit.org/show_bug.cgi?id=48693
Summary Add idl and mock classes for FileWriterSync.
Eric U.
Reported 2010-10-29 15:44:06 PDT
The implementation will follow soon after.
Attachments
Patch (19.53 KB, patch)
2010-10-29 18:04 PDT, Eric U. 		no flags
DetailsFormatted DiffDiff
Patch (19.56 KB, patch)
2010-11-08 18:09 PST, Eric U. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric U.
Comment 1 2010-10-29 18:04:35 PDT
Created attachment 72423 [details] Patch
David Levin
Comment 2 2010-11-01 11:29:39 PDT
Comment on attachment 72423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review > WebCore/ChangeLog:19 > + * bindings/scripts/CodeGeneratorV8.pm: And android's build file? So many build files.... > WebCore/fileapi/FileWriterSync.h:54 > + void write(Blob* data, ExceptionCode& ec); No need for param name "ec". > WebCore/fileapi/FileWriterSync.h:55 > + void seek(long long position, ExceptionCode& ec); Ditto. > WebCore/fileapi/FileWriterSync.h:56 > + void truncate(long long length, ExceptionCode& ec); Ditto. > WebCore/fileapi/FileWriterSync.h:73 > + friend class WTF::RefCounted<FileWriterSync>; I believe that WTF:: is unnecessary.
Eric U.
Comment 3 2010-11-08 16:04:54 PST
(In reply to comment #2) > (From update of attachment 72423 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review > > > WebCore/ChangeLog:19 > > + * bindings/scripts/CodeGeneratorV8.pm: > > And android's build file? It looks like Android doesn't have any support for FILE_SYSTEM classes in any of its build files yet. How about I open a separate bug for that? > So many build files.... Sigh. Oh, for a meta-build system. > > WebCore/fileapi/FileWriterSync.h:54 > > + void write(Blob* data, ExceptionCode& ec); > > No need for param name "ec". Fixed. > > WebCore/fileapi/FileWriterSync.h:55 > > + void seek(long long position, ExceptionCode& ec); > > Ditto. > > > WebCore/fileapi/FileWriterSync.h:56 > > + void truncate(long long length, ExceptionCode& ec); > > Ditto. > > > WebCore/fileapi/FileWriterSync.h:73 > > + friend class WTF::RefCounted<FileWriterSync>; > > I believe that WTF:: is unnecessary. Fixed.
Eric U.
Comment 4 2010-11-08 16:31:49 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 72423 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=72423&action=review > > > > > WebCore/ChangeLog:19 > > > + * bindings/scripts/CodeGeneratorV8.pm: > > > > And android's build file? > > It looks like Android doesn't have any support for FILE_SYSTEM classes in any of its build files yet. How about I open a separate bug for that? > > > So many build files.... > > Sigh. Oh, for a meta-build system. > > > > WebCore/fileapi/FileWriterSync.h:54 > > > + void write(Blob* data, ExceptionCode& ec); > > > > No need for param name "ec". > > Fixed. > > > > WebCore/fileapi/FileWriterSync.h:55 > > > + void seek(long long position, ExceptionCode& ec); > > > > Ditto. > > > > > WebCore/fileapi/FileWriterSync.h:56 > > > + void truncate(long long length, ExceptionCode& ec); > > > > Ditto. > > > > > WebCore/fileapi/FileWriterSync.h:73 > > > + friend class WTF::RefCounted<FileWriterSync>; > > > > I believe that WTF:: is unnecessary. > > Fixed. [will hopefully upload shortly; I'm having some build issues right now]
Eric U.
Comment 5 2010-11-08 18:09:02 PST
Created attachment 73325 [details] Patch
WebKit Commit Bot
Comment 6 2010-11-09 20:03:17 PST
Comment on attachment 73325 [details] Patch Clearing flags on attachment: 73325 Committed r71711: <http://trac.webkit.org/changeset/71711>
WebKit Commit Bot
Comment 7 2010-11-09 20:03:23 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-11-09 20:58:41 PST
http://trac.webkit.org/changeset/71711 might have broken Chromium Win Release
Note You need to log in before you can comment on or make changes to this bug.