173405 – [iOS] Always include frames in the scrolling tree when fast frame scrolling is enabled

RESOLVED FIXED 173405

[iOS] Always include frames in the scrolling tree when fast frame scrolling is enabled

https://bugs.webkit.org/show_bug.cgi?id=173405

Summary [iOS] Always include frames in the scrolling tree when fast frame scrolling i...

Frédéric Wang (:fredw)

Reported 2017-06-15 01:39:47 PDT

Same as bug 172851, but for iOS and for frame flattening.

Attachments
Patch (5.75 KB, patch) 2017-06-15 02:21 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.29 MB, application/zip) 2017-06-15 03:28 PDT, Build Bot	no flags	Details
Patch (10.23 KB, patch) 2017-06-15 03:44 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.30 MB, application/zip) 2017-06-15 05:11 PDT, Build Bot	no flags	Details
alternative Patch (6.04 KB, patch) 2017-06-15 06:35 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (10.51 KB, patch) 2017-06-15 07:53 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (173359+173405) (23.89 KB, patch) 2017-06-19 06:19 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (8.14 KB, patch) 2017-06-19 07:21 PDT, Frédéric Wang (:fredw)	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2017-06-15 02:21:59 PDT

Created attachment 312965 [details] Patch

Build Bot

Comment 2 2017-06-15 03:28:08 PDT

Comment on attachment 312965 [details] Patch Attachment 312965 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3934570 New failing tests: imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html fast/frames/frame-scrolling-attribute.html imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin.html fast/text-autosizing/ios/contenteditable.html fast/frames/frameset-style-recalc.html compositing/iframes/iframe-copy-on-scroll.html fast/frames/take-focus-from-iframe.html tables/mozilla/bugs/bug131020.html compositing/iframes/iframe-in-composited-layer.html fast/scrolling/scrolling-tree-includes-frame.html fast/overflow/scrollRevealButton.html fast/frames/iframe-scrolling-attribute.html compositing/iframes/overlapped-iframe-iframe.html fast/regions/repaint/line-flow-with-floats-in-regions.html fast/forms/basic-textareas.html

Build Bot

Comment 3 2017-06-15 03:28:09 PDT

Created attachment 312967 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Frédéric Wang (:fredw)

Comment 4 2017-06-15 03:44:03 PDT

Created attachment 312968 [details] Patch

Build Bot

Comment 5 2017-06-15 05:11:10 PDT

Comment on attachment 312968 [details] Patch Attachment 312968 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3934943 New failing tests: imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html fast/frames/frameset-style-recalc.html imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin.html fast/text-autosizing/ios/contenteditable.html fast/frames/frame-scrolling-attribute.html compositing/iframes/iframe-copy-on-scroll.html fast/frames/take-focus-from-iframe.html tables/mozilla/bugs/bug131020.html compositing/iframes/iframe-in-composited-layer.html fast/overflow/scrollRevealButton.html fast/frames/iframe-scrolling-attribute.html compositing/iframes/overlapped-iframe-iframe.html fast/regions/repaint/line-flow-with-floats-in-regions.html fast/forms/basic-textareas.html

Build Bot

Comment 6 2017-06-15 05:11:11 PDT

Created attachment 312970 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Frédéric Wang (:fredw)

Comment 7 2017-06-15 06:35:19 PDT

Created attachment 312976 [details] alternative Patch

Frédéric Wang (:fredw)

Comment 8 2017-06-15 07:53:42 PDT

Created attachment 312980 [details] Patch

Frédéric Wang (:fredw)

Comment 9 2017-06-15 23:01:27 PDT

As I see, some frames are already be included in the scrolling tree after bug 133665. So I guess I should come back to the initial idea of making this for all frames when frame flattening is disabled.

Frédéric Wang (:fredw)

Comment 10 2017-06-15 23:02:16 PDT

Comment on attachment 312980 [details] Patch Cancelling review per Simon's comments on IRC.

Frédéric Wang (:fredw)

Comment 11 2017-06-19 06:19:35 PDT

Created attachment 313286 [details] Patch (173359+173405)

Frédéric Wang (:fredw)

Comment 12 2017-06-19 07:21:21 PDT

Created attachment 313293 [details] Patch This patch applies on top of bug 173359.

Frédéric Wang (:fredw)

Comment 13 2017-06-19 23:06:27 PDT

Committed r218535: <http://trac.webkit.org/changeset/218535>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Frames

Assignee

Frédéric Wang (:fredw)

Reported

2017-06-15 01:39 PDT

Modified

2017-06-19 23:06 PDT History

CC List

3 users Show

URL

Keywords

Depends on

133665 173359

Blocks

149264

Dependencies

tree graph