173359 – [Mac] Add an experimental feature setting for fast frame scrolling

RESOLVED FIXED 173359

[Mac] Add an experimental feature setting for fast frame scrolling

https://bugs.webkit.org/show_bug.cgi?id=173359

Summary [Mac] Add an experimental feature setting for fast frame scrolling

Frédéric Wang (:fredw)

Reported 2017-06-14 02:18:38 PDT

This will allow developers to test fast-scrollable frames on Mac, without having to change defaultScrollingTreeIncludesFrames.

Attachments
Patch (24.86 KB, patch) 2017-06-14 08:23 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (24.83 KB, patch) 2017-06-14 08:31 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1011.81 KB, application/zip) 2017-06-14 09:33 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.15 MB, application/zip) 2017-06-14 09:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.75 MB, application/zip) 2017-06-14 09:55 PDT, Build Bot	no flags	Details
Patch (23.64 KB, patch) 2017-06-14 13:21 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (11.23 KB, patch) 2017-06-19 03:11 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (685.61 KB, application/zip) 2017-06-19 04:21 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-elcapitan (978.21 KB, application/zip) 2017-06-19 04:30 PDT, Build Bot	no flags	Details
Patch (16.39 KB, patch) 2017-06-19 05:43 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (22.30 KB, patch) 2017-06-19 06:59 PDT, Frédéric Wang (:fredw)	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2017-06-14 08:23:26 PDT

Created attachment 312889 [details] Patch

Frédéric Wang (:fredw)

Comment 2 2017-06-14 08:31:38 PDT

Created attachment 312890 [details] Patch

Build Bot

Comment 3 2017-06-14 09:33:55 PDT

Comment on attachment 312890 [details] Patch Attachment 312890 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3929927 New failing tests: platform/mac/fast/scrolling/set-fast-frame-scrolling.html

Build Bot

Comment 4 2017-06-14 09:33:56 PDT

Created attachment 312892 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-06-14 09:43:30 PDT

Comment on attachment 312890 [details] Patch Attachment 312890 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3929934 New failing tests: platform/mac/fast/scrolling/set-fast-frame-scrolling.html

Build Bot

Comment 6 2017-06-14 09:43:32 PDT

Created attachment 312894 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-06-14 09:55:14 PDT

Comment on attachment 312890 [details] Patch Attachment 312890 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3929949 New failing tests: platform/mac/fast/scrolling/set-fast-frame-scrolling.html

Build Bot

Comment 8 2017-06-14 09:55:16 PDT

Created attachment 312899 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 9 2017-06-14 10:26:28 PDT

Comment on attachment 312890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312890&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:167 > +#if PLATFORM(MAC) > + void setFastFrameScrollingEnabled(bool isEnabled) { m_isFastFrameScrollingEnabled = isEnabled; } > + bool fastFrameScrollingEnabled() const { return m_isFastFrameScrollingEnabled; } > +#endif Why can't this be a Setting?

Frédéric Wang (:fredw)

Comment 10 2017-06-14 13:21:13 PDT

Created attachment 312918 [details] Patch

Simon Fraser (smfr)

Comment 11 2017-06-15 10:47:52 PDT

Comment on attachment 312918 [details] Patch Why isn't fast frame scrolling a Setting?

Frédéric Wang (:fredw)

Comment 12 2017-06-19 00:17:45 PDT

Comment on attachment 312918 [details] Patch After discussion with Simon on irc, all what we want is a settings for "Fast Frame Scrolling" that can be an "experimental feature" (e.g. like SpringTimingFunctionEnabled) not a "runtime flag" (deprecated). I'll upload a new patch soon.

Frédéric Wang (:fredw)

Comment 13 2017-06-19 03:11:46 PDT

Created attachment 313272 [details] Patch

Build Bot

Comment 14 2017-06-19 04:21:19 PDT

Comment on attachment 313272 [details] Patch Attachment 313272 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3956806 Number of test failures exceeded the failure limit.

Build Bot

Comment 15 2017-06-19 04:21:21 PDT

Created attachment 313273 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 16 2017-06-19 04:30:50 PDT

Comment on attachment 313272 [details] Patch Attachment 313272 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3956823 New failing tests: inspector/canvas/create-canvas-contexts.html

Build Bot

Comment 17 2017-06-19 04:30:51 PDT

Created attachment 313274 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Frédéric Wang (:fredw)

Comment 18 2017-06-19 05:43:47 PDT

Created attachment 313279 [details] Patch

Frédéric Wang (:fredw)

Comment 19 2017-06-19 06:59:38 PDT

Created attachment 313289 [details] Patch

Simon Fraser (smfr)

Comment 20 2017-06-19 13:09:18 PDT

Comment on attachment 313289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313289&action=review > Source/WebCore/page/Settings.in:179 > +fastFrameScrollingEnabled initial=false I wonder if we should call this "asyncScrolling" since we have AsyncScrollingCoordinator.

Frédéric Wang (:fredw)

Comment 21 2017-06-19 23:05:05 PDT

Committed r218534: <http://trac.webkit.org/changeset/218534>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Frames

Assignee

Frédéric Wang (:fredw)

Reported

2017-06-14 02:18 PDT

Modified

2017-06-19 23:05 PDT History

CC List

5 users Show

URL

Keywords

Depends on

Blocks

171667 173405

Dependencies

tree graph