NEW 152162
B3 should be able to sink values into checks 
https://bugs.webkit.org/show_bug.cgi?id=152162
Summary B3 should be able to sink values into checks
Filip Pizlo
Reported 2015-12-10 18:55:27 PST
B3 should sink sinkable operations to the lowest dominating point in the CFG. In case an operation's output is only used for the stackmap of Check, we should turn this: @a = Foo(...) Check(@p, @a) into this: Branch(@p, #exit, #continuation) exit: @a = Foo(...) Check(false, @a) contination: ... This will help with the useless Shr that we will see on some array bounds checks from asm.js code.
Attachments
Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-12-10 18:56:11 PST
(In reply to comment #0) > B3 should sink sinkable operations to the lowest dominating point in the > CFG. In case an operation's output is only used for the stackmap of Check, > we should turn this: > > @a = Foo(...) > Check(@p, @a) > > into this: > > Branch(@p, #exit, #continuation) > > exit: > @a = Foo(...) > Check(false, @a) > > contination: > ... > > This will help with the useless Shr that we will see on some array bounds > checks from asm.js code. It's worth saying that usually, https://bugs.webkit.org/show_bug.cgi?id=152160 will obviate the need for this. But things may leak past that optimization. This optimization is more general, but it has a compile time cost due to the introduction of control flow.
Filip Pizlo
Comment 2 2015-12-12 22:26:22 PST
The priority right now is sinking into checks, not general sinking.
Filip Pizlo
Comment 3 2016-02-28 17:50:43 PST
Note that we could sink anything that the CSE can reason about. For example, we could sink stores into checks!
Note You need to log in before you can comment on or make changes to this bug.