RESOLVED FIXED 99908
[CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS Shaders is loaded. 
https://bugs.webkit.org/show_bug.cgi?id=99908
Summary [CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS ...
Dongseong Hwang
Reported 2012-10-19 23:58:28 PDT
CSS Shaders can not render anything until the program is loaded. If there is partial loaded shaders program, whole FilterOperations chain can not render anything. It occurs a flash. So We have to wait until the program is loaded, to prevent a flash as RenderLayerBacking::updateImageContents() waits until an image is fully loaded.
Attachments
Patch (2.58 KB, patch)
2012-10-20 00:11 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-10-20 00:11:27 PDT
Created attachment 169759 [details] Patch
Noam Rosenthal
Comment 2 2012-10-20 09:12:38 PDT
Comment on attachment 169759 [details] Patch This seems like a platform specific behavior - when we set the filters on a particular GraphicsLayer (e.g. CoordinatedGraphicsLayer) we can subscribe to the program as a client and reset the filters when the program is loaded.
Dongseong Hwang
Comment 3 2012-10-20 20:05:22 PDT
(In reply to comment #2) > (From update of attachment 169759 [details]) > This seems like a platform specific behavior - when we set the filters on a particular GraphicsLayer (e.g. CoordinatedGraphicsLayer) we can subscribe to the program as a client and reset the filters when the program is loaded. Thanks for good opinion. We already subscribe to the program when the program is loaded, because WebCore recalculates the style when the program is loaded. I think both approaches can be right. Each GraphicsLayer easily resets the filters, but I prefer this patch because of two reasons. 1. Each platform needs to have similar code to handle unloaded programs. 2. As I mentioned in Changelog, RenderLayerBacking::updateImageContents() already waits calling GraphicsLayer::setContentsToImage() until an image is fully loaded. I want RenderLayerBacking to handle CachedProgram similar to CachedImage. I think same policy increases code readability. I'm looking forward your feedback :)
Dean Jackson
Comment 4 2012-10-23 14:36:47 PDT
Comment on attachment 169759 [details] Patch I'm not sure this is the right thing to do, but I'll r+ so that we can live on it for a while. Sometimes I think a flash is better than nothing.
WebKit Review Bot
Comment 5 2012-10-23 14:45:59 PDT
Comment on attachment 169759 [details] Patch Clearing flags on attachment: 169759 Committed r132270: <http://trac.webkit.org/changeset/132270>
WebKit Review Bot
Comment 6 2012-10-23 14:46:04 PDT
All reviewed patches have been landed. Closing bug.
Dongseong Hwang
Comment 7 2012-10-23 14:48:13 PDT
(In reply to comment #4) > (From update of attachment 169759 [details]) > I'm not sure this is the right thing to do, but I'll r+ so that we can live on it for a while. Sometimes I think a flash is better than nothing. Thank you for your review. I think so, it is not the best way. We will find more proper solution.
Note You need to log in before you can comment on or make changes to this bug.