RESOLVED FIXED 99366
ResourceLoader::sendResourceLoadCallbacks() is backwards 
https://bugs.webkit.org/show_bug.cgi?id=99366
Summary ResourceLoader::sendResourceLoadCallbacks() is backwards
Nate Chapin
Reported 2012-10-15 14:17:51 PDT
...it does an implicit enum to bool conversion which returns the opposite value of what is intended. It isn't used currently, but will be used in a later patch for supporting main resources in the memory cache.
Attachments
patch (1.37 KB, patch)
2012-10-15 14:23 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2012-10-15 14:23:25 PDT
Created attachment 168781 [details] patch
Daniel Bates
Comment 2 2012-10-15 22:06:31 PDT
Comment on attachment 168781 [details] patch This patch looks straightforward to me.
WebKit Review Bot
Comment 3 2012-10-15 22:14:47 PDT
Comment on attachment 168781 [details] patch Clearing flags on attachment: 168781 Committed r131411: <http://trac.webkit.org/changeset/131411>
WebKit Review Bot
Comment 4 2012-10-15 22:14:50 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2012-10-16 10:29:18 PDT
Comment on attachment 168781 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=168781&action=review > Source/WebCore/ChangeLog:3 > + ResourceLoader::sendResourceLoadCallbacks() is backwards It's also badly misnamed. A function with this name should send callbacks when called, not just access a member variable.
Nate Chapin
Comment 6 2012-10-16 10:30:44 PDT
(In reply to comment #5) > (From update of attachment 168781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168781&action=review > > > Source/WebCore/ChangeLog:3 > > + ResourceLoader::sendResourceLoadCallbacks() is backwards > > It's also badly misnamed. A function with this name should send callbacks when called, not just access a member variable. ...I never noticed that. Now it irritates me. Will fix :)
Note You need to log in before you can comment on or make changes to this bug.