RESOLVED FIXED 98892
HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters. 
https://bugs.webkit.org/show_bug.cgi?id=98892
Summary HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parame...
Mike West
Reported 2012-10-10 06:04:14 PDT
HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters.
Attachments
Patch (2.01 KB, patch)
2012-10-10 06:06 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (2.03 KB, patch)
2012-10-10 06:32 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-10-10 06:06:59 PDT
Created attachment 167985 [details] Patch
jochen
Comment 2 2012-10-10 06:11:52 PDT
Comment on attachment 167985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167985&action=review > Source/WebCore/html/HTMLTextFormControlElement.cpp:162 > + placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden", false); "important" defaults to false so you could also just omit it
Mike West
Comment 3 2012-10-10 06:15:12 PDT
(In reply to comment #2) > (From update of attachment 167985 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167985&action=review > > > Source/WebCore/html/HTMLTextFormControlElement.cpp:162 > > + placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden", false); > > "important" defaults to false so you could also just omit it Even better. Thanks. :)
Mike West
Comment 4 2012-10-10 06:32:05 PDT
Created attachment 167990 [details] Patch
WebKit Review Bot
Comment 5 2012-10-10 06:56:10 PDT
Comment on attachment 167990 [details] Patch Clearing flags on attachment: 167990 Committed r130897: <http://trac.webkit.org/changeset/130897>
WebKit Review Bot
Comment 6 2012-10-10 06:56:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.