RESOLVED FIXED 98162
[EFL] Use XvfbDriver for layout tests 
https://bugs.webkit.org/show_bug.cgi?id=98162
Summary [EFL] Use XvfbDriver for layout tests
Chris Dumez
Reported 2012-10-02 08:16:38 PDT
We should use XvfbDriver for layout tests so that tests that requires a running X server can be unskipped on the build bots.
Attachments
Patch (2.76 KB, patch)
2012-10-02 08:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-02 08:43:00 PDT
Created attachment 166692 [details] Patch
Chris Dumez
Comment 2 2012-10-02 09:07:39 PDT
xvfb is now installed on both Intel build bots. I added xvfb dependency to: https://trac.webkit.org/wiki/WebKitEFLLayoutTest
Laszlo Gombos
Comment 3 2012-10-02 09:33:47 PDT
(In reply to comment #2) > xvfb is now installed on both Intel build bots. Is there an expectation on the xvfb version ? Predictability and consistent environment for LayoutTests are very important (and using xvfb should help with that). IMHO we should recommend the xvfb version that runs on the buildbot. Would that be v2.1.11+ ?
Chris Dumez
Comment 4 2012-10-02 09:36:01 PDT
(In reply to comment #3) > (In reply to comment #2) > > xvfb is now installed on both Intel build bots. > > Is there an expectation on the xvfb version ? Predictability and consistent environment for LayoutTests are very important (and using xvfb should help with that). > > IMHO we should recommend the xvfb version that runs on the buildbot. Would that be v2.1.11+ ? The build bots are running Ubuntu 12.04 so they have xfvb v1.11.4, yes.
WebKit Review Bot
Comment 5 2012-10-02 10:53:25 PDT
Comment on attachment 166692 [details] Patch Clearing flags on attachment: 166692 Committed r130186: <http://trac.webkit.org/changeset/130186>
WebKit Review Bot
Comment 6 2012-10-02 10:53:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.