NEW 96455
run-perf-tests --build-directory shouldn't assume subdirectories. 
https://bugs.webkit.org/show_bug.cgi?id=96455
Summary run-perf-tests --build-directory shouldn't assume subdirectories.
Stephanie Lewis
Reported 2012-09-11 18:00:28 PDT
Thanks for adding --build-directory. It would be nice if it didn't assume that there would be subdirectories named Release or Debug. There are other flavors of builds. I'd prefer it to match run-webkit-tests where --root points directly at the folder containing the app and frameworks.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-09-13 13:21:01 PDT
Is your request to add --root? I don't think we should change the semantics of --build-directory as it'll be confusing for run-perf-tests and run-webkit-tests to interpret the same option differently.
Stephanie Lewis
Comment 2 2012-09-13 14:23:03 PDT
I guess I am. I didn't even realize --build-directory was an option for run-webkit-tests.
Ryosuke Niwa
Comment 3 2012-09-13 20:34:43 PDT
See https://bugs.webkit.org/show_bug.cgi?id=91890 and http://trac.webkit.org/changeset/123530. My current plan is to get rid of --build-directory in run-webkit-tests, and then replace --build-directory by --root in run-perf-tests. We should probably rename --root though... it's such a cryptic name...
Zoltan Horvath
Comment 4 2012-09-22 00:54:35 PDT
(In reply to comment #3) > See https://bugs.webkit.org/show_bug.cgi?id=91890 and http://trac.webkit.org/changeset/123530. > > My current plan is to get rid of --build-directory in run-webkit-tests, and then replace --build-directory by --root in run-perf-tests. > > We should probably rename --root though... it's such a cryptic name... Now in run-webkit-tests --root is looking for the binary in bin/ directory, it doesn't seem much better than --build-directory. I support to make these things clear!
Note You need to log in before you can comment on or make changes to this bug.