RESOLVED FIXED 95842
[EFL][WK2] Provide implementation for TestRunner::pathToLocalResource() 
https://bugs.webkit.org/show_bug.cgi?id=95842
Summary [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
Chris Dumez
Reported Wednesday, September 5, 2012 1:23:20 PM UTC
WK2 EFL WebKitTestRunner currently has a very basic implementation of TestRunner::pathToLocalResource() method (it merely returns the argument). We need to map /tmp to ${DUMPRENDERTREE_TEMP} envar and /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} envar as we do for WK1 EFL DumpRenderTree. This causes some test cases for fail for WK2-EFL, including: fast/dom/frame-loading-via-document-write.html
Attachments
Patch (4.29 KB, patch)
2012-09-05 05:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 Wednesday, September 5, 2012 1:34:48 PM UTC
Created attachment 162228 [details] Patch
Kenneth Rohde Christiansen
Comment 2 Wednesday, September 5, 2012 1:44:29 PM UTC
Comment on attachment 162228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162228&action=review > Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:62 > JSRetainPtr<JSStringRef> TestRunner::pathToLocalResource(JSStringRef url) > { > - return url; > + String requestedUrl(url->characters(), url->length()); Shouldn't you verify it is local? assert? > Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:66 > + if (requestedUrl.find("LayoutTests") != notFound) { Shouldn't it start with it? or is that not needed
Chris Dumez
Comment 3 Wednesday, September 5, 2012 1:55:20 PM UTC
Comment on attachment 162228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162228&action=review >> Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:62 >> + String requestedUrl(url->characters(), url->length()); > > Shouldn't you verify it is local? assert? The function is called pathTo*Local*Resource() so I assumed it was not needed. FYI, I merely copied the implementation from DumpRenderTree. >> Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:66 >> + if (requestedUrl.find("LayoutTests") != notFound) { > > Shouldn't it start with it? or is that not needed Technically, it needs to start with file:///tmp/LayoutTests. This is a copy of the DRT implementation but I can improve it.
WebKit Review Bot
Comment 4 Wednesday, September 5, 2012 5:33:28 PM UTC
Comment on attachment 162228 [details] Patch Clearing flags on attachment: 162228 Committed r127602: <http://trac.webkit.org/changeset/127602>
WebKit Review Bot
Comment 5 Wednesday, September 5, 2012 5:33:32 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.