WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95385
IndexedDB: remove final createIndex backend glue
https://bugs.webkit.org/show_bug.cgi?id=95385
Summary
IndexedDB: remove final createIndex backend glue
Alec Flett
Reported
2012-08-29 14:56:54 PDT
IndexedDB: remove final createIndex backend glue
Attachments
Patch
(14.58 KB, patch)
2012-08-29 14:58 PDT
,
Alec Flett
no flags
Details
Formatted Diff
Diff
Patch
(14.57 KB, patch)
2012-08-29 15:25 PDT
,
Alec Flett
no flags
Details
Formatted Diff
Diff
Patch
(24.97 KB, patch)
2012-08-29 17:08 PDT
,
Alec Flett
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alec Flett
Comment 1
2012-08-29 14:58:23 PDT
Created
attachment 161323
[details]
Patch
WebKit Review Bot
Comment 2
2012-08-29 15:01:29 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 3
2012-08-29 15:01:47 PDT
Attachment 161323
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4
2012-08-29 15:13:17 PDT
Comment on
attachment 161323
[details]
Patch
Attachment 161323
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13694403
Alec Flett
Comment 5
2012-08-29 15:25:02 PDT
Created
attachment 161331
[details]
Patch
Alec Flett
Comment 6
2012-08-29 15:26:01 PDT
jsbell/dgrogan - anything I missed here?
kov's GTK+ EWS bot
Comment 7
2012-08-29 15:31:57 PDT
Comment on
attachment 161331
[details]
Patch
Attachment 161331
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/13691398
Joshua Bell
Comment 8
2012-08-29 15:37:26 PDT
Can these be cleaned up too? WebKit/chromium/public/platform/WebKitPlatformSupport.h WebKit/chromium/src/PlatformSupport.cpp WebCore/platform/chromium/PlatformSupport.h
Build Bot
Comment 9
2012-08-29 15:52:10 PDT
Comment on
attachment 161331
[details]
Patch
Attachment 161331
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13689427
Gyuyoung Kim
Comment 10
2012-08-29 16:27:02 PDT
Comment on
attachment 161331
[details]
Patch
Attachment 161331
[details]
did not pass efl-ews (efl): Output:
http://queues.webkit.org/results/13689446
Alec Flett
Comment 11
2012-08-29 17:08:28 PDT
Created
attachment 161363
[details]
Patch
Alec Flett
Comment 12
2012-09-04 15:55:58 PDT
abarth@ - quick review for code removal?
Adam Barth
Comment 13
2012-09-04 17:17:07 PDT
Comment on
attachment 161363
[details]
Patch So many red lines!
WebKit Review Bot
Comment 14
2012-09-04 17:56:02 PDT
Comment on
attachment 161363
[details]
Patch Clearing flags on attachment: 161363 Committed
r127535
: <
http://trac.webkit.org/changeset/127535
>
WebKit Review Bot
Comment 15
2012-09-04 17:56:07 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug