RESOLVED FIXED 94768
[V8] Move evaluate() from V8Proxy to ScriptController 
https://bugs.webkit.org/show_bug.cgi?id=94768
Summary [V8] Move evaluate() from V8Proxy to ScriptController
Kentaro Hara
Reported 2012-08-22 19:14:45 PDT
To kill V8Proxy, we can move evaluate() from V8Proxy to ScriptController.
Attachments
Patch (12.60 KB, patch)
2012-08-22 19:19 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-22 19:19:10 PDT
Created attachment 160067 [details] Patch
Adam Barth
Comment 2 2012-08-22 20:03:38 PDT
Comment on attachment 160067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160067&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:309 > + v8::Handle<v8::Context> v8Context = ScriptController::mainWorldContext(m_proxy->frame()); m_proxy->frame() is just m_frame, right?
Kentaro Hara
Comment 3 2012-08-22 20:42:35 PDT
Committed r126388: <http://trac.webkit.org/changeset/126388>
Kentaro Hara
Comment 4 2012-08-22 20:43:16 PDT
(In reply to comment #2) > > + v8::Handle<v8::Context> v8Context = ScriptController::mainWorldContext(m_proxy->frame()); > > m_proxy->frame() is just m_frame, right? Done. Thanks.
Note You need to log in before you can comment on or make changes to this bug.