RESOLVED FIXED 93818
[V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h 
https://bugs.webkit.org/show_bug.cgi?id=93818
Summary [V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
Kentaro Hara
Reported 2012-08-13 04:05:44 PDT
We can move the GCEventData class from V8Binding.h to ScriptGCEvent.h.
Attachments
Patch (5.78 KB, patch)
2012-08-13 04:09 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-13 04:09:00 PDT
Created attachment 157957 [details] Patch
Adam Barth
Comment 2 2012-08-13 10:32:46 PDT
Comment on attachment 157957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157957&action=review > Source/WebCore/bindings/v8/ScriptGCEvent.h:58 > + GCEventData() : m_startTime(0.0), m_usedHeapSize(0) { } This should be split onto a bunch of lines. > Source/WebCore/bindings/v8/ScriptGCEvent.h:63 > + } Can you add blank lines between member functions that have multi-line bodies?
Kentaro Hara
Comment 3 2012-08-13 18:46:18 PDT
Committed r125494: <http://trac.webkit.org/changeset/125494>
Note You need to log in before you can comment on or make changes to this bug.