Created attachment 157496 [details] Patch

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Comment on attachment 157496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157496&action=review > LayoutTests/http/tests/media/media-source/video-media-source-objects.html:49 > + testExpected("segmentHelper.sourceBuffer.timestampOffset", 5); There are some chromium changes that need to land before this test runs properly. Otherwise, this patch is ready for review.

Comment on attachment 157496 [details] Patch Attachment 157496 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13460655 New failing tests: http/tests/media/media-source/video-media-source-objects.html

Created attachment 157528 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment on attachment 157496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157496&action=review The non-chromium change look OK to me. Not marking r+ because I am not abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org. > LayoutTests/http/tests/media/media-source/video-media-source-objects.html:77 > + consoleWrite("Test that setting timestampOffset throws and error when the MediaSource is not associated with a media element."); Nit: I think you want "throws an error"

Comment on attachment 157496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157496&action=review >> LayoutTests/http/tests/media/media-source/video-media-source-objects.html:49 >> + testExpected("segmentHelper.sourceBuffer.timestampOffset", 5); > > There are some chromium changes that need to land before this test runs properly. Otherwise, this patch is ready for review. These have landed and tests should run properly now. >> LayoutTests/http/tests/media/media-source/video-media-source-objects.html:77 >> + consoleWrite("Test that setting timestampOffset throws and error when the MediaSource is not associated with a media element."); > > Nit: I think you want "throws an error" Done. Thanks!

Created attachment 158052 [details] fix typo and rerun tests

Committed r125682: <http://trac.webkit.org/changeset/125682>