RESOLVED FIXED 93205
Refactor console logging out of CSPDirectiveList into ContentSecurityPolicy 
https://bugs.webkit.org/show_bug.cgi?id=93205
Summary Refactor console logging out of CSPDirectiveList into ContentSecurityPolicy
Mike West
Reported 2012-08-05 12:12:36 PDT
Currently, CSPDirectiveList is the only piece of ContentSecurityPolicy's architecture that can log to the console. I think we can improve the situation by extracting the logging functions and moving them to the policy object, and then teaching each of the lower-level objects about the policy in which they live.
Attachments
Patch (24.21 KB, patch)
2012-08-06 01:45 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-08-06 01:45:08 PDT
Created attachment 156624 [details] Patch
Mike West
Comment 2 2012-08-06 01:47:18 PDT
Hey Adam, this is a pass at the refactoring I asked you about over the weekend. In a nut, it replaces the dependence on ScriptExecutionContext with a dependence on ContentSecurityPolicy, adding a few new methods to CSP in order to route a few of the context-relevant requests through the policy object. Not high priority, so just take a look whenever you have a chance. :) Thanks!
Adam Barth
Comment 3 2012-08-07 15:26:33 PDT
Thanks.
Mike West
Comment 4 2012-08-08 01:27:16 PDT
Comment on attachment 156624 [details] Patch Danke! CQ?
WebKit Review Bot
Comment 5 2012-08-08 04:57:00 PDT
Comment on attachment 156624 [details] Patch Clearing flags on attachment: 156624 Committed r125021: <http://trac.webkit.org/changeset/125021>
WebKit Review Bot
Comment 6 2012-08-08 04:57:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.