RESOLVED FIXED 93115
[V8] Remove V8Proxy::registerExtensionWithV8() 
https://bugs.webkit.org/show_bug.cgi?id=93115
Summary [V8] Remove V8Proxy::registerExtensionWithV8()
Kentaro Hara
Reported 2012-08-03 07:13:30 PDT
V8Proxy::registerExtensionWithV8() is used by V8Proxy::registerExtension() only. We can remove the redundant method. In a follow-up patch, I will implement V8Proxy::registerExtentionIfNeeded() and remove registerExtensionWithV8() and registerExtension().
Attachments
Patch (3.69 KB, patch)
2012-08-03 07:15 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (3.80 KB, patch)
2012-08-05 07:04 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-03 07:15:52 PDT
Created attachment 156369 [details] Patch
Adam Barth
Comment 2 2012-08-03 09:55:55 PDT
Comment on attachment 156369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156369&action=review > Source/WebCore/bindings/v8/V8Proxy.cpp:678 > +const V8Extensions& V8Proxy::extensions() Why have both staticExtensionsList() and V8Proxy::extensions() ?
Kentaro Hara
Comment 3 2012-08-03 09:59:03 PDT
(In reply to comment #2) > (From update of attachment 156369 [details]) > > Source/WebCore/bindings/v8/V8Proxy.cpp:678 > > +const V8Extensions& V8Proxy::extensions() > > Why have both staticExtensionsList() and V8Proxy::extensions() ? - staticExtensionsList() is not const and can be used by V8Proxy.cpp only. - extensions() is const and can be used by outside (i.e. V8DOMWindowShell.cpp) Shall we merge them by removing const?
Adam Barth
Comment 4 2012-08-03 10:23:18 PDT
> Shall we merge them by removing const? I'm not sure it's a big deal either way. I leave it up to your judgement.
Kentaro Hara
Comment 5 2012-08-03 10:24:52 PDT
(In reply to comment #4) > > Shall we merge them by removing const? > > I'm not sure it's a big deal either way. I leave it up to your judgement. OK, let me merge them and land it (after depending patches are landed).
Kentaro Hara
Comment 6 2012-08-05 07:04:01 PDT
Created attachment 156558 [details] patch for landing
WebKit Review Bot
Comment 7 2012-08-05 08:39:45 PDT
Comment on attachment 156558 [details] patch for landing Clearing flags on attachment: 156558 Committed r124716: <http://trac.webkit.org/changeset/124716>
Note You need to log in before you can comment on or make changes to this bug.