RESOLVED FIXED 92842
[WIN] Add missing WTF export macros to functions 
https://bugs.webkit.org/show_bug.cgi?id=92842
Summary [WIN] Add missing WTF export macros to functions
Patrick R. Gansterer
Reported 2012-07-31 23:13:32 PDT
[WIN] Add missing WTF export macros to functions
Attachments
Patch (4.58 KB, patch)
2012-07-31 23:18 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (4.61 KB, patch)
2012-08-01 02:00 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-07-31 23:18:28 PDT
Created attachment 155726 [details] Patch
Hajime Morrita
Comment 2 2012-07-31 23:27:24 PDT
Comment on attachment 155726 [details] Patch The change looks innocent. Please update before landing.
Patrick R. Gansterer
Comment 3 2012-08-01 02:00:10 PDT
Created attachment 155758 [details] Patch
WebKit Review Bot
Comment 4 2012-08-01 02:03:06 PDT
Attachment 155758 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Th..." exit_code: 1 Source/WTF/wtf/unicode/UTF8.h:79: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 5 2012-08-01 02:16:50 PDT
Comment on attachment 155726 [details] Patch Cleared Hajime Morita's review+ from obsolete attachment 155726 [details] so that this bug does not appear in http://webkit.org/pending-commit.
WebKit Review Bot
Comment 6 2012-08-01 03:08:12 PDT
Comment on attachment 155758 [details] Patch Clearing flags on attachment: 155758 Committed r124320: <http://trac.webkit.org/changeset/124320>
WebKit Review Bot
Comment 7 2012-08-01 03:08:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.