WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
92764
[Chromium] Don't use ninja for building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=92764
Summary
[Chromium] Don't use ninja for building Chromium for Android
Peter Beverloo
Reported
2012-07-31 08:59:18 PDT
[Chromium] Don't use ninja for building Chromium for Android
Attachments
Patch
(1.58 KB, patch)
2012-07-31 09:00 PDT
,
Peter Beverloo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Peter Beverloo
Comment 1
2012-07-31 09:00:48 PDT
Created
attachment 155554
[details]
Patch
Peter Beverloo
Comment 2
2012-07-31 09:03:16 PDT
I reverted (and Yaron re-landed)
http://crrev.com/148739
on the Chromium side, which enabled creating Ninja project files. This unintentionally switched Android to using the Ninja build, which then broke. We should eventually make the switch, but do so in a controlled and tested manner.
WebKit Review Bot
Comment 3
2012-07-31 10:27:06 PDT
Comment on
attachment 155554
[details]
Patch Clearing flags on attachment: 155554 Committed
r124219
: <
http://trac.webkit.org/changeset/124219
>
WebKit Review Bot
Comment 4
2012-07-31 10:27:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug