RESOLVED FIXED 92621
Refactor EventDispatcher::dispatchEvent() so that we can call each phase (Caputure, Target and Bubbling) of event dispatching separately. 
https://bugs.webkit.org/show_bug.cgi?id=92621
Summary Refactor EventDispatcher::dispatchEvent() so that we can call each phase (Cap...
Hayato Ito
Reported 2012-07-30 02:03:11 PDT
This is one of the required refactorings to support event propagation of seamless iframes. It might be worth nothing that we can get rid of 'goto' sentence from EventDispatcher by this refactoring.
Attachments
wip (9.83 KB, patch)
2012-07-30 03:37 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
wip (10.94 KB, patch)
2012-07-30 04:58 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
'goto' is gone. (10.99 KB, patch)
2012-07-30 05:11 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
sync ToT (15.61 KB, patch)
2012-07-30 06:29 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Fix weird ChangeLog enty (10.51 KB, patch)
2012-07-30 06:33 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-02 (307.40 KB, application/zip)
2012-07-30 09:14 PDT, WebKit Review Bot 		no flags
Details
unroll eventDispatchInitialize (10.21 KB, patch)
2012-07-30 17:15 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.16 KB, patch)
2012-07-31 17:35 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-07-30 03:37:10 PDT
Created attachment 155245 [details] wip
Hayato Ito
Comment 2 2012-07-30 04:58:54 PDT
Created attachment 155264 [details] wip
Hayato Ito
Comment 3 2012-07-30 05:11:14 PDT
Created attachment 155266 [details] 'goto' is gone.
Hayato Ito
Comment 4 2012-07-30 06:29:31 PDT
Created attachment 155280 [details] sync ToT
Hayato Ito
Comment 5 2012-07-30 06:33:17 PDT
Created attachment 155281 [details] Fix weird ChangeLog enty
WebKit Review Bot
Comment 6 2012-07-30 09:14:00 PDT
Comment on attachment 155281 [details] Fix weird ChangeLog enty Attachment 155281 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13392371 New failing tests: platform/chromium/compositing/accelerated-drawing/svg-filters.html platform/chromium/compositing/accelerated-drawing/alpha.html
WebKit Review Bot
Comment 7 2012-07-30 09:14:04 PDT
Created attachment 155300 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Dimitri Glazkov (Google)
Comment 8 2012-07-30 09:26:54 PDT
Comment on attachment 155281 [details] Fix weird ChangeLog enty View in context: https://bugs.webkit.org/attachment.cgi?id=155281&action=review Neat! > Source/WebCore/dom/EventDispatcher.cpp:242 > + dispatchEventInitialize(event); This seems like a very function. Can we unroll it here?
Hayato Ito
Comment 9 2012-07-30 17:15:17 PDT
Created attachment 155403 [details] unroll eventDispatchInitialize
Hayato Ito
Comment 10 2012-07-30 17:16:05 PDT
Thank you for the review. (In reply to comment #8) > (From update of attachment 155281 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155281&action=review > > Neat! > > > Source/WebCore/dom/EventDispatcher.cpp:242 > > + dispatchEventInitialize(event); > > This seems like a very function. Can we unroll it here? Sure. Done.
Dimitri Glazkov (Google)
Comment 11 2012-07-31 10:05:47 PDT
Comment on attachment 155403 [details] unroll eventDispatchInitialize ok, let's give it a try. Wow, we're getting rid of one of the oldest gotos in the code.
WebKit Review Bot
Comment 12 2012-07-31 16:51:39 PDT
Comment on attachment 155403 [details] unroll eventDispatchInitialize Rejecting attachment 155403 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13389870
Hayato Ito
Comment 13 2012-07-31 17:35:46 PDT
Created attachment 155689 [details] Patch for landing
WebKit Review Bot
Comment 14 2012-07-31 20:42:07 PDT
Comment on attachment 155689 [details] Patch for landing Clearing flags on attachment: 155689 Committed r124291: <http://trac.webkit.org/changeset/124291>
WebKit Review Bot
Comment 15 2012-07-31 20:42:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.