Created attachment 154350 [details] Patch

The RunChromiumWebKitUnitTests, RunWebKitTests and RunUnitTests (which is TestWebKitAPI) steps are still broken, but the modifications required there can be made on the scripts' side and won't require master modifications. After this and fixing the steps, all that remains should be adding the bot itself. Hardware is standing by, devices should be available shortly. Lucas: ETA for adding the "Chromium Android Release (Tests)" bot should be roughly one to two weeks, would this work for you? Longer-term, say 1-2 months, we'd also like to add a "Chromium Android Release (Perf)" bot.

Comment on attachment 154350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154350&action=review > Tools/BuildSlaveSupport/built-product-archive:172 > + ignorePatterns = ['.svn', '*.a', '*.d', '*.dSYM', '*.o', '*.ilk', '*.lib', '*.idb', > + 'BuildLog.htm', '*.obj', '*.pdb', '*.pch', '*.tlog', '*.lastbuildstate'] > + > + if fullPlatform and fullPlatform == 'chromium-android': > + ignorePatterns.extend(['*.so', '*.pak', '*-unaligned.apk']) Should we just ignore these files all the time? For example, we ignore both *.obj and *.o even though those never exist on the same OS.

Created attachment 154361 [details] Patch

(In reply to comment #3) > Should we just ignore these files all the time? For example, we ignore both *.obj and *.o even though those never exist on the same OS. I answered that in the ChangeLog (maybe too verbose..?): at least the Chromium Mac and Linux builders contain .so files in their out directory, i.e. for ffmpegsudo. Since it's there, I've *assumed* that the libraries are being used. *.pak and *-unaligned.apk would be safe to add to the general list, but since we have to make this separation anyway I thought it would be clearer to add them here.

Comment on attachment 154361 [details] Patch I fail at reading. Thanks.

Lucas, do you have comments about this? Otherwise I'll put it on the CQ.

Comment on attachment 154361 [details] Patch I think this should be ok, fire away.

Comment on attachment 154361 [details] Patch Ok, thank you!

Comment on attachment 154361 [details] Patch Clearing flags on attachment: 154361 Committed r125066: <http://trac.webkit.org/changeset/125066>

All reviewed patches have been landed. Closing bug.