RESOLVED FIXED 92077
[EFL][WK2] Fix possible crash in didSendRequestForResource 
https://bugs.webkit.org/show_bug.cgi?id=92077
Summary [EFL][WK2] Fix possible crash in didSendRequestForResource
Chris Dumez
Reported Tuesday, July 24, 2012 9:11:25 AM UTC
In ewk_view_resource_load_client's didSendRequestForResource(), we need to check that the wkRedirectResponse is not NULL before using it. The redirect response may indeed may NULL if there was no redirection.
Attachments
Patch (3.07 KB, patch)
2012-07-24 01:19 PDT, Chris Dumez 		kenneth: review+
DetailsFormatted DiffDiff
Patch for landing (3.08 KB, patch)
2012-07-24 01:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 Tuesday, July 24, 2012 9:19:13 AM UTC
Created attachment 153984 [details] Patch
Kenneth Rohde Christiansen
Comment 2 Tuesday, July 24, 2012 9:24:46 AM UTC
Comment on attachment 153984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153984&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.h:164 > + Ewk_Url_Response *redirect_response; /**< Possible redirect response for the resource (may be @c NULL) */ Redirect response if a redirect occurred or NULL (or similar)
Chris Dumez
Comment 3 Tuesday, July 24, 2012 9:30:12 AM UTC
Created attachment 153985 [details] Patch for landing Fixed Kenneth's nit. Could someone please cq+ ?
WebKit Review Bot
Comment 4 Tuesday, July 24, 2012 10:21:55 AM UTC
Comment on attachment 153985 [details] Patch for landing Clearing flags on attachment: 153985 Committed r123444: <http://trac.webkit.org/changeset/123444>
WebKit Review Bot
Comment 5 Tuesday, July 24, 2012 10:22:00 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.