RESOLVED FIXED 91888
[Qt] WebViewLoadFavIcon::test_favIconLoad() fails 
https://bugs.webkit.org/show_bug.cgi?id=91888
Summary [Qt] WebViewLoadFavIcon::test_favIconLoad() fails
Rafael Brandao
Reported 2012-07-20 11:58:27 PDT
[Qt] WebViewLoadFavIcon::test_favIconLoad() fails
Attachments
Patch (1.91 KB, patch)
2012-07-20 11:59 PDT, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Patch (1.94 KB, patch)
2012-07-30 15:03 PDT, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2012-07-20 11:59:58 PDT
Created attachment 153554 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2012-07-20 12:21:08 PDT
Comment on attachment 153554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153554&action=review Looks good to me. But I have a question :-) > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:40 > verify(webView.waitForLoadSucceeded()) > + spy.wait() Do we even need to webView.waitForLoadSucceeded here? > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:51 > verify(webView.waitForLoadSucceeded()) > + spy.wait() And here.
Rafael Brandao
Comment 3 2012-07-30 15:03:24 PDT
Created attachment 155374 [details] Patch
Rafael Brandao
Comment 4 2012-07-30 15:05:07 PDT
Makes sense. Unfortunately the bug is no longer showing up on my machine because it's now faster and it seems it's neither showing up on buildbot. But for me it's clear that there's a problem there, so I'm all for upstreaming this patch. :-)
WebKit Review Bot
Comment 5 2012-08-10 09:30:39 PDT
Comment on attachment 155374 [details] Patch Clearing flags on attachment: 155374 Committed r125291: <http://trac.webkit.org/changeset/125291>
WebKit Review Bot
Comment 6 2012-08-10 09:30:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.