WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
91740
WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED should be defined in Platform.h instead of wtf/Atomics.h
https://bugs.webkit.org/show_bug.cgi?id=91740
Summary
WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED should be defined in Platform.h instead...
Wei James (wistoch)
Reported
2012-07-19 06:43:03 PDT
WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED is defined in wtf/Atomic.h, which should be in Platform.h
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2012-07-19 09:07:20 PDT
Can you please provide the rationale? We have most USE macros defined in Platform.h indeed, but it's not great to dump them all together in one file. So, I'm honestly unsure if this would be an improvement.
Wei James (wistoch)
Comment 2
2012-07-19 09:11:50 PDT
(In reply to
comment #1
)
> Can you please provide the rationale? We have most USE macros defined in Platform.h indeed, but it's not great to dump them all together in one file. So, I'm honestly unsure if this would be an improvement.
see
https://bugs.webkit.org/show_bug.cgi?id=89428#c16
there may be some misunderstanding in the
bug #89428
, peter asked me to put a MACRO in platform.h instead of Atomic.h. I misunderstood him and thought we shoudl put all MACRO in platform.h instead of Atomics.h. please ignore this bug entry. thanks
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug