WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91717
DFG cell checks should be hoisted
https://bugs.webkit.org/show_bug.cgi?id=91717
Summary
DFG cell checks should be hoisted
Filip Pizlo
Reported
2012-07-18 23:38:19 PDT
Patch forthcoming.
Attachments
the patch
(13.62 KB, patch)
2012-07-18 23:47 PDT
,
Filip Pizlo
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2012-07-18 23:47:30 PDT
Created
attachment 153189
[details]
the patch
WebKit Review Bot
Comment 2
2012-07-18 23:51:04 PDT
Attachment 153189
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:1000: testq_rm is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3
2012-07-19 10:51:44 PDT
Comment on
attachment 153189
[details]
the patch r=me
Filip Pizlo
Comment 4
2012-07-19 20:52:52 PDT
Landed in
http://trac.webkit.org/changeset/123169
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug