RESOLVED INVALID 90780
Move WorkQueue to WTF 
https://bugs.webkit.org/show_bug.cgi?id=90780
Summary Move WorkQueue to WTF
Kwang Yul Seo
Reported 2012-07-09 05:27:10 PDT
Currently, WorkQueue is in WebKit2. By moving WorkQueue and PlatformProcessIdentifier to WTF, WebCore code can use it. This patch is required for parallel image decoders because WorkQueue is used to make image decoding off the main thread.
Attachments
Patch (125.10 KB, patch)
2012-07-09 05:44 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (126.60 KB, patch)
2012-07-09 05:58 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (126.56 KB, patch)
2012-07-09 06:00 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (126.72 KB, patch)
2012-07-09 06:03 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (129.15 KB, patch)
2012-07-11 00:51 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (131.80 KB, patch)
2012-07-11 01:32 PDT, Kwonjin Jeong 		no flags
DetailsFormatted DiffDiff
Patch (126.77 KB, patch)
2012-07-25 18:25 PDT, Kwonjin Jeong 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-07-09 05:44:00 PDT
Created attachment 151238 [details] Patch
Build Bot
Comment 2 2012-07-09 05:49:37 PDT
Comment on attachment 151238 [details] Patch Attachment 151238 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13157819
Early Warning System Bot
Comment 3 2012-07-09 05:49:54 PDT
Comment on attachment 151238 [details] Patch Attachment 151238 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13162259
Kwang Yul Seo
Comment 4 2012-07-09 05:58:18 PDT
Created attachment 151240 [details] Patch
Kwang Yul Seo
Comment 5 2012-07-09 06:00:04 PDT
Created attachment 151241 [details] Patch
Kwang Yul Seo
Comment 6 2012-07-09 06:03:28 PDT
Created attachment 151242 [details] Patch
Build Bot
Comment 7 2012-07-09 06:24:38 PDT
Comment on attachment 151242 [details] Patch Attachment 151242 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13157829
Kwang Yul Seo
Comment 8 2012-07-09 07:10:58 PDT
I will fix the build soon ;(
Build Bot
Comment 9 2012-07-09 09:00:27 PDT
Comment on attachment 151242 [details] Patch Attachment 151242 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13164293
Kwonjin Jeong
Comment 10 2012-07-11 00:51:09 PDT
Created attachment 151627 [details] Patch
Zoltan Horvath
Comment 11 2012-07-11 00:56:06 PDT
It's another task, but later it would be nice to merge ParallelJobs (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/ParallelJobs.h) and the moved WorkQueue.
Kwang Yul Seo
Comment 12 2012-07-11 00:57:47 PDT
(In reply to comment #10) > Created an attachment (id=151627) [details] > Patch Thanks for build fix!
Kwang Yul Seo
Comment 13 2012-07-11 01:05:04 PDT
(In reply to comment #11) > It's another task, but later it would be nice to merge ParallelJobs (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/ParallelJobs.h) and the moved WorkQueue. Isn't ParallelJobs for data parallelism? How can they be merged?
Build Bot
Comment 14 2012-07-11 01:17:17 PDT
Comment on attachment 151627 [details] Patch Attachment 151627 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13166727
Kwonjin Jeong
Comment 15 2012-07-11 01:32:41 PDT
Created attachment 151643 [details] Patch
Kwang Yul Seo
Comment 16 2012-07-11 02:18:17 PDT
I think we can improve WorkQueue later to satisfy the requirements of ThreadCommunication ( https://trac.webkit.org/wiki/ThreadCommunication ). CC'ing Levin for further discussion.
Kwonjin Jeong
Comment 17 2012-07-25 18:25:22 PDT
Created attachment 154508 [details] Patch
Build Bot
Comment 18 2012-07-26 14:21:19 PDT
Comment on attachment 154508 [details] Patch Attachment 154508 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13368055
Kwang Yul Seo
Comment 19 2012-08-06 22:22:02 PDT
We are working on 90869 instead. Close this bug as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.