WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
90757
BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized.
https://bugs.webkit.org/show_bug.cgi?id=90757
Summary
BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is no...
Dongseong Hwang
Reported
2012-07-08 23:59:51 PDT
The current code fortunately has worked so far because only BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized. startAnimation returns at the first line becase shouldAnimate() always return false in this case. if (m_frameTimer || !shouldAnimate() || frameCount() <= 1) return; This change is needed because parallel image decoders call BitmapImage::frameIsCompleteAtIndex in other places too.
Attachments
Patch
(2.11 KB, patch)
2012-07-09 01:04 PDT
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2012-07-09 01:04:18 PDT
Created
attachment 151205
[details]
Patch
Kwang Yul Seo
Comment 2
2012-07-11 14:03:58 PDT
Comment on
attachment 151205
[details]
Patch Clearing flags on attachment: 151205 Committed
r122368
: <
http://trac.webkit.org/changeset/122368
>
Kwang Yul Seo
Comment 3
2012-07-11 14:04:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug