RESOLVED DUPLICATE of bug 87680 90091
[Qt] REGRESSION(r121348): It made 500+ tests flakey 
https://bugs.webkit.org/show_bug.cgi?id=90091
Summary [Qt] REGRESSION(r121348): It made 500+ tests flakey
Csaba Osztrogonác
Reported 2012-06-27 12:24:28 PDT
http://trac.webkit.org/changeset/121349 made 500+ tests flakey on Qt bots and it made the bots exit early, so the Qt bot is useless because of this bug. http://build.webkit.org/builders/Qt%20Linux%20Release/builds/48817 http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release/builds/39264 Could you check it, please?
Attachments
Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-27 12:39:28 PDT
András, have you got any idea what caused this annoying sideeffect bug? Simon, what should we do in this case? Skip 500+ test? Rollout the patch which cause it? Maybe it is innocent and there are a serious bug in QtWebKit somewhere ... Or leave the bots broken?
Csaba Osztrogonác
Comment 2 2012-06-27 12:49:08 PDT
I forgot to mention that it is Qt-WK1 related bug. It is valid on Qt 4.8 and Qt 5.0 WebKit, but everything works on Qt 5.0 WK2.
Simon Hausmann
Comment 3 2012-06-27 13:06:14 PDT
(In reply to comment #1) > András, have you got any idea what caused this annoying sideeffect bug? > > Simon, what should we do in this case? Skip 500+ test? Rollout the patch which cause it? Maybe it is innocent and there are a serious bug in QtWebKit somewhere ... Or leave the bots broken? My first impression is as well that the patch is innocent. Unfortunately I'm without a build machine for the next couple of days, otherwise I'd give this a try myself, but here's what I'd do: 1) Try to reproduce the failures locally 2) See if reverting just that patch _does_ fix it (I doubt it) 3) Bisect down to the change that caused it or 4) Find out that it's some weird miscompilation or unclean build issue that this particular patch just uncovered by accident.
Csaba Osztrogonác
Comment 4 2012-06-28 00:01:30 PDT
r121349 is innocent, http://trac.webkit.org/changeset/121348 is the culprit. With r121347 everything works, and with r121348 tests are flakey. I tried reverting r121348 on ToT, and it solved the problem for me. Now I'm trying to find what caused the problem. My first idea is that the new css3/filters/blur-filter-page-scroll.html does something wrong.
Csaba Osztrogonác
Comment 5 2012-06-28 00:20:12 PDT
Oh, I got it. AcceleratedCompositingEnabled and MockScrollBarsEnabled isn't reset after each test in Qt's DRT. :-/ What a pathetic bug! Here is the bug report for MockScrollBarsEnabled - https://bugs.webkit.org/show_bug.cgi?id=87680
Csaba Osztrogonác
Comment 6 2012-06-28 00:22:22 PDT
*** This bug has been marked as a duplicate of bug 87680 ***
Note You need to log in before you can comment on or make changes to this bug.