RESOLVED FIXED 89720
[Chromium] Release media resources after each LayoutTest on Android 
https://bugs.webkit.org/show_bug.cgi?id=89720
Summary [Chromium] Release media resources after each LayoutTest on Android
Adam Barth
Reported 2012-06-21 17:31:58 PDT
[Chromium] Release media resources after each LayoutTest on Android
Attachments
Patch (1.46 KB, patch)
2012-06-21 17:33 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2012-06-22 18:34 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-06-21 17:33:45 PDT
Created attachment 148922 [details] Patch
Kent Tamura
Comment 2 2012-06-21 18:34:44 PDT
Comment on attachment 148922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 > + webkit_support::ReleaseMediaResources(); I couldn't find ReleaseMediaResources() in webkit_support.h r142549.
Adam Barth
Comment 3 2012-06-22 10:17:28 PDT
(In reply to comment #2) > (From update of attachment 148922 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review > > > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 > > + webkit_support::ReleaseMediaResources(); > > I couldn't find ReleaseMediaResources() in webkit_support.h r142549. We might need to upstream some patches from the chromium-android branch to Chromium first. /me will investigate.
Adam Barth
Comment 4 2012-06-22 11:11:41 PDT
@tkent: You're totally right. I'm going to figure out how big that iceberg is.
Adam Barth
Comment 5 2012-06-22 15:53:03 PDT
Chromium CL: https://chromiumcodereview.appspot.com/10664003/
Tony Chang
Comment 6 2012-06-22 15:59:42 PDT
Comment on attachment 148922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review >>> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 >>> + webkit_support::ReleaseMediaResources(); >> >> I couldn't find ReleaseMediaResources() in webkit_support.h r142549. > > We might need to upstream some patches from the chromium-android branch to Chromium first. /me will investigate. Should we move this to resetTestController?
Adam Barth
Comment 7 2012-06-22 16:02:06 PDT
Comment on attachment 148922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148922&action=review >>>> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:131 >>>> + webkit_support::ReleaseMediaResources(); >>> >>> I couldn't find ReleaseMediaResources() in webkit_support.h r142549. >> >> We might need to upstream some patches from the chromium-android branch to Chromium first. /me will investigate. > > Should we move this to resetTestController? Sure.
Adam Barth
Comment 8 2012-06-22 18:34:48 PDT
Created attachment 149153 [details] Patch
Adam Barth
Comment 9 2012-06-22 18:35:14 PDT
This should be ready to land once Bug 89800 lands.
Adam Barth
Comment 10 2012-06-24 00:59:51 PDT
*** Bug 66230 has been marked as a duplicate of this bug. ***
Adam Barth
Comment 11 2012-06-24 01:59:18 PDT
Comment on attachment 149153 [details] Patch Bug 89800 has landed. This patch is ready for review/landing.
WebKit Review Bot
Comment 12 2012-06-24 09:29:43 PDT
Comment on attachment 149153 [details] Patch Clearing flags on attachment: 149153 Committed r121118: <http://trac.webkit.org/changeset/121118>
WebKit Review Bot
Comment 13 2012-06-24 09:29:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.