RESOLVED FIXED 89333
[Qt] REGRESSION(r120311): It made inspector/extensions/extensions-panel.html flakey 
https://bugs.webkit.org/show_bug.cgi?id=89333
Summary [Qt] REGRESSION(r120311): It made inspector/extensions/extensions-panel.html ...
Csaba Osztrogonác
Reported 2012-06-18 00:03:52 PDT
http://trac.webkit.org/changeset/120311 made inspector/extensions/extensions-panel.html flakey at least on Qt platform. It fails intermittently with the following diff: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-actual.txt @@ -21,8 +21,8 @@ createStatusBarButton : <function> show : <function> } +Panel shown Extension panel size correct -Panel shown RUNNING TEST: extension_testStatusBarButtons Created a status bar button, dump follows: { Could you check it, please?
Attachments
Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-18 00:16:12 PDT
You can easily reproduce the bug: $ Tools/Scripts/old-run-webkit-tests inspector/extensions/extensions-panel.html --iterations 100 --singly 54 test cases (54%) succeeded 46 test cases (46%) had incorrect layout
János Badics
Comment 2 2012-06-18 05:56:58 PDT
I skipped this test on Qt until it is fixed. See http://trac.webkit.org/changeset/120590
Csaba Osztrogonác
Comment 3 2012-06-18 08:39:30 PDT
(In reply to comment #2) > I skipped this test on Qt until it is fixed. See > http://trac.webkit.org/changeset/120590 Great ... after skipping this test, inspector/extensions/extensions-reload.html started to fail constantly ... Have you got any idea? --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-actual.txt @@ -1,11 +1,8 @@ +FAIL: Timed out waiting for notifyDone to be called Tests that webInspector.inspectedWindow.reload() successfully injects user's code upon reload Started extension. +Page reloaded. Running tests... RUNNING TEST: extension_testReloadInjectsCode -Page reloaded. -Page reloaded. -With injected code: foo = 42 -Without injected code: foo = undefined -All tests done.
Csaba Osztrogonác
Comment 4 2012-06-18 08:49:44 PDT
(In reply to comment #3) > (In reply to comment #2) > > I skipped this test on Qt until it is fixed. See > > http://trac.webkit.org/changeset/120590 > > Great ... after skipping this test, inspector/extensions/extensions-reload.html started to fail constantly ... > > Have you got any idea? > > --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-expected.txt > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-reload-actual.txt > @@ -1,11 +1,8 @@ > +FAIL: Timed out waiting for notifyDone to be called > Tests that webInspector.inspectedWindow.reload() successfully injects user's code upon reload > > Started extension. > +Page reloaded. > Running tests... > RUNNING TEST: extension_testReloadInjectsCode > -Page reloaded. > -Page reloaded. > -With injected code: foo = 42 > -Without injected code: foo = undefined > -All tests done. I filed a new bug report on this new bug: https://bugs.webkit.org/show_bug.cgi?id=89349
Andrey Kosyakov
Comment 5 2012-07-10 09:22:27 PDT
Should be fixed by r122216: http://trac.webkit.org/changeset/122216
Note You need to log in before you can comment on or make changes to this bug.