RESOLVED FIXED 88945
webkitpy: rework the TestExpectations style checker in preparation for the cascade 
https://bugs.webkit.org/show_bug.cgi?id=88945
Summary webkitpy: rework the TestExpectations style checker in preparation for the ca...
Dirk Pranke
Reported 2012-06-12 19:29:56 PDT
webkitpy: rework the TestExpectations style checker in preparation for the cascade
Attachments
Patch (4.14 KB, patch)
2012-06-12 19:30 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-12 19:30:48 PDT
Created attachment 147216 [details] Patch
Ojan Vafai
Comment 2 2012-06-13 09:42:31 PDT
Comment on attachment 147216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147216&action=review > Tools/Scripts/webkitpy/style/checkers/test_expectations.py:82 > + expectations = parser.parse('expectations', expectations_str) > + if overrides: > + expectations += parser.parse('overrides', overrides) This should have a FIXME to handle cascading expectations properly. I think each style error line should probably print out the file the style error is in.
Dirk Pranke
Comment 3 2012-06-13 10:12:30 PDT
(In reply to comment #2) > (From update of attachment 147216 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147216&action=review > > > Tools/Scripts/webkitpy/style/checkers/test_expectations.py:82 > > + expectations = parser.parse('expectations', expectations_str) > > + if overrides: > > + expectations += parser.parse('overrides', overrides) > > This should have a FIXME to handle cascading expectations properly. > > I think each style error line should probably print out the file the style error is in. Probably, but that'll require reworking this file further; right now the style checker just passes the string in so we don't even know the filename. As a sidenote, I'm pretty sure the overrides flag is always False and isn't actually used. I'll add some comments, though. Thanks for the reviews!
Dirk Pranke
Comment 4 2012-06-13 12:46:21 PDT
Committed r120238: <http://trac.webkit.org/changeset/120238>
Note You need to log in before you can comment on or make changes to this bug.