Created attachment 147031 [details] Added cmake script for TestNetscapePlugin

Comment on attachment 147031 [details] Added cmake script for TestNetscapePlugin View in context: https://bugs.webkit.org/attachment.cgi?id=147031&action=review > Tools/CMakeLists.txt:6 > + ADD_SUBDIRECTORY(DumpRenderTree/TestNetscapePlugIn) You commented that this is required for WTR/EFL, but it is in DRT/. Isn't it required DRT also? I want to know whether this make the results of DRT better. > Tools/ChangeLog:4 > + Added cmake script for TestNetscapePlugin > + https://bugs.webkit.org/show_bug.cgi?id=88756 Bug title is different. > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:8 > + ${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/main.cpp > + ${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/Tests/DocumentOpenInDestroyStream.cpp We commonly give an empty line when folder is changed in sour lists. > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:35 > +ADD_LIBRARY(TestNetscapePlugin SHARED ${WebKitTestNetscapePlugin_SOURCES}) > + Empty line is not necessary.

Created attachment 147198 [details] Added cmake script for TestNetscapePlugin This patch is just for building TestNetscapePlugin. Basically, all the plugin tests require this TestNetscapePlugin. The test script on DRT and WTR should be changed for this plugin, I think. In case of WTR, environment variable TEST_RUNNER_TEST_PLUGIN_PATH is needed for plugin test.

(In reply to comment #3) > Created an attachment (id=147198) [details] > Added cmake script for TestNetscapePlugin > > This patch is just for building TestNetscapePlugin. > Basically, all the plugin tests require this TestNetscapePlugin. > > The test script on DRT and WTR should be changed for this plugin, I think. > In case of WTR, environment variable TEST_RUNNER_TEST_PLUGIN_PATH is needed for plugin test. I have a question. How can WTR recognize TEST_RUNNER_TEST_PLUGIN_PATH environment variable ? Does WTR already support it ?

(In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=147198) [details] [details] > > Added cmake script for TestNetscapePlugin > > > > This patch is just for building TestNetscapePlugin. > > Basically, all the plugin tests require this TestNetscapePlugin. > > > > The test script on DRT and WTR should be changed for this plugin, I think. > > In case of WTR, environment variable TEST_RUNNER_TEST_PLUGIN_PATH is needed for plugin test. > > I have a question. How can WTR recognize TEST_RUNNER_TEST_PLUGIN_PATH environment variable ? Does WTR already support it ? The test script for WTR is implemented locally, but it's not contributed yet. As I know, Kangil Han has a plan to contribute the test script for WTR.

Informal rs+ on my side for EFL WTR support.

Looks fine to me, too.

Bug 87659 can be solved without this, So I will remove the dependency.

Comment on attachment 147198 [details] Added cmake script for TestNetscapePlugin Clearing flags on attachment: 147198 Committed r123859: <http://trac.webkit.org/changeset/123859>

All reviewed patches have been landed. Closing bug.