RESOLVED FIXED 86665
Use pixelSnappedLogicalHeight for TableSection layout 
https://bugs.webkit.org/show_bug.cgi?id=86665
Summary Use pixelSnappedLogicalHeight for TableSection layout
Levi Weintraub
Reported 2012-05-16 12:33:08 PDT
Previously, we were using logicalHeight but storing the value as an int in RenderTableSection. We *want* to use ints, but we need to pixel snap the value.
Attachments
Patch (2.85 KB, patch)
2012-05-16 13:16 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-05-16 13:16:26 PDT
Created attachment 142329 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-16 18:27:31 PDT
Comment on attachment 142329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142329&action=review > Source/WebCore/rendering/RenderBox.h:77 > + int pixelSnappedLogicalHeight() const { return style()->isHorizontalWritingMode() ? pixelSnappedHeight() : pixelSnappedWidth(); } > + int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); } So sad that we have all these redundant accessors. One would think that a logicalSize() might make more sense. :)
Levi Weintraub
Comment 3 2012-05-16 18:29:07 PDT
Comment on attachment 142329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142329&action=review >> Source/WebCore/rendering/RenderBox.h:77 >> + int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); } > > So sad that we have all these redundant accessors. One would think that a logicalSize() might make more sense. :) Thanks for the review! I smell some potential cleanup :)
WebKit Review Bot
Comment 4 2012-05-16 20:36:39 PDT
Comment on attachment 142329 [details] Patch Clearing flags on attachment: 142329 Committed r117388: <http://trac.webkit.org/changeset/117388>
WebKit Review Bot
Comment 5 2012-05-16 20:36:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.