RESOLVED WONTFIX 86499
[Chromium] IndexedDB: Allow a default data directory to be specified for IDBFactory 
https://bugs.webkit.org/show_bug.cgi?id=86499
Summary [Chromium] IndexedDB: Allow a default data directory to be specified for IDBF...
Joshua Bell
Reported 2012-05-15 10:45:33 PDT
[Chromium] IndexedDB: Allow a default data directory to be specified for IDBFactory
Attachments
Patch (4.93 KB, patch)
2012-05-15 11:52 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-05-15 11:52:52 PDT
Created attachment 142018 [details] Patch
WebKit Review Bot
Comment 2 2012-05-15 11:56:29 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Joshua Bell
Comment 3 2012-05-15 11:59:16 PDT
The corresponding Chromium changes will live in src/webkit/support/test_webkit_platform_support.{h,cc} - TestWebKitPlatformSupport will have a ScopedTempDir and pass it through to WebIDBFactory::create in TestWebKitPlatformSupport::idbFactory
Joshua Bell
Comment 4 2012-05-15 12:15:42 PDT
Chromium side is: https://chromiumcodereview.appspot.com/10382180
David Grogan
Comment 5 2012-05-15 14:38:08 PDT
LGTM
Joshua Bell
Comment 6 2012-05-15 16:36:13 PDT
Updated patches to https://chromiumcodereview.appspot.com/10382180 can do this w/o a WebKit API change, which is preferable.
James Robinson
Comment 7 2012-05-15 16:48:52 PDT
Comment on attachment 142018 [details] Patch Clearing review? flag to remove this from webkit.org/pending-review
Note You need to log in before you can comment on or make changes to this bug.