Created attachment 141652 [details] Patch

Comment on attachment 141652 [details] Patch I believe you're still missing the changes to vsprops files for Windows builds. You can land them as a separate patch.

Ok, I'll follow up with the windows changes. Thanks.

Comment on attachment 141652 [details] Patch Rejecting attachment 141652 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: org/svn/trunk/src/webkit@136942 parsed_url: http://src.chromium.org/svn/trunk/src/webkit@136942 should_process: True processed: True deps_parsed: True requirements: ('./',) Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' No such file or directory at Tools/Scripts/update-webkit line 118. Full output: http://queues.webkit.org/results/12685495

Comment on attachment 141652 [details] Patch Clearing flags on attachment: 141652 Committed r117028: <http://trac.webkit.org/changeset/117028>

All reviewed patches have been landed. Closing bug.

It broke a unittest: Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py", line 113, in test_skipped_directories_for_symbols self.assertEqual(result_directories, expected_directories) AssertionError: set(['mathml', 'compositing/webgl', 'fast/canvas/webgl', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables']) != set(['compositing/webgl', 'mathml', 'http/tests/canvas/webgl', 'mhtml', 'fast/canvas/webgl'])

Reopening to attach new patch.

Created attachment 141869 [details] Patch

(In reply to comment #8) > Reopening to attach new patch. Sorry, I didn't want to reopen the bug (because it is forbidden by ap), webkit-patch did it automatically.

Comment on attachment 141869 [details] Patch Could you file another bug for this? This bug summary is apparently misleading.

(In reply to comment #11) > (From update of attachment 141869 [details]) > Could you file another bug for this? This bug summary is apparently misleading. No, I don't have time for this burocracy ... Feel free to reuse my patch ...

Comment on attachment 141869 [details] Patch Considering that the changelog mentions broken revision. it's Ok to land this.

Comment on attachment 141869 [details] Patch Clearing flags on attachment: 141869 Committed r117053: <http://trac.webkit.org/changeset/117053>

All reviewed patches have been landed. Closing bug.

(In reply to comment #15) > All reviewed patches have been landed. Closing bug.

Comment on attachment 141652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141652&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:303 > + "CSSVariableValue": ["fast/css/variables"], Is this really working? I don't know if this is port-specific but on EFL port, there is no CSSVariableVariable symbol in libwebcore_efl.so after turning on the CSS_VARIABLES flag. As a consequence, the test cases get skipped even though they pass if forced.

Comment on attachment 141652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141652&action=review >> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:303 >> + "CSSVariableValue": ["fast/css/variables"], > > Is this really working? I don't know if this is port-specific but on EFL port, there is no CSSVariableVariable symbol in libwebcore_efl.so after turning on the CSS_VARIABLES flag. As a consequence, the test cases get skipped even though they pass if forced. Actually, the "CSSVariableValue" symbol is present if I build in debug mode but not if I build in release.

Ok, I assume that's true for the way other tests are skipped too, but if I've got it wrong, I want to know about it.