WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
86144
Integrate IETC CSS : xml namespace tests
https://bugs.webkit.org/show_bug.cgi?id=86144
Summary
Integrate IETC CSS : xml namespace tests
Dave Tharp
Reported
2012-05-10 14:09:36 PDT
Integrate 17 IETC xml namespace tests. Three of these fail and will have bugs written against them.
Attachments
Patch
(72.10 KB, patch)
2012-05-10 14:18 PDT
,
Dave Tharp
no flags
Details
Formatted Diff
Diff
Patch
(71.23 KB, patch)
2012-05-11 14:48 PDT
,
Tom Zakrajsek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dave Tharp
Comment 1
2012-05-10 14:18:24 PDT
Created
attachment 141252
[details]
Patch
Tom Zakrajsek
Comment 2
2012-05-11 14:48:11 PDT
Created
attachment 141500
[details]
Patch
Tom Zakrajsek
Comment 3
2012-05-11 14:52:28 PDT
Committed
r116808
: <
http://trac.webkit.org/changeset/116808
>
WebKit Review Bot
Comment 4
2012-05-11 14:52:28 PDT
Attachment 141500
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/iete..." exit_code: 1 LayoutTests/platform/gtk/test_expectations.txt:1337: Path does not exist. svg/text/add-tspan-position-bug.html [test/expectations] [5] LayoutTests/platform/gtk/test_expectations.txt:1338: Path does not exist. svg/text/modify-tspan-position-bug.html [test/expectations] [5] Total errors found: 2 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tom Zakrajsek
Comment 5
2012-05-11 14:59:43 PDT
OK, so just to 'splain... Adam Barth r+'d the first patch. Merge and manual commit was required because of test_expectations conflict. As I was doing that, a well-intentioned gardener added bustage to gtk's expectations. I decided not to do gardener combat, and committed with the style violation. Hopefully that was OK.
Dave Tharp
Comment 6
2012-05-14 10:27:59 PDT
Patch expertly landed by tomz :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug