RESOLVED FIXED 86083
TouchAdjustment doesn't correct for scroll-offsets 
https://bugs.webkit.org/show_bug.cgi?id=86083
Summary TouchAdjustment doesn't correct for scroll-offsets
Allan Sandfeld Jensen
Reported 2012-05-10 04:05:47 PDT
The two functions EventHandler::bestClickableNodeForTouchPoint and EventHandler::bestZoomableAreaForTouchPoint does not correctly adjust for scroll-offset. Scroll-offset is only taking into account for calculating distance, but not in hit-testing or in returned adjusted values. This is in case corrected in Internals to make the test-cases work, but it should be done generally.
Attachments
Patch (4.45 KB, patch)
2012-05-10 04:08 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-05-10 04:08:49 PDT
Created attachment 141139 [details] Patch
Terry Anderson
Comment 2 2012-05-10 08:02:35 PDT
I just uploaded a revised patch for https://bugs.webkit.org/show_bug.cgi?id=85101, which takes the scroll offset/frame issues into account for chromium. But in light of this bug, I will have to re-revise.
WebKit Review Bot
Comment 3 2012-05-10 09:17:11 PDT
Comment on attachment 141139 [details] Patch Clearing flags on attachment: 141139 Committed r116650: <http://trac.webkit.org/changeset/116650>
WebKit Review Bot
Comment 4 2012-05-10 09:17:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.