RESOLVED LATER 86045
[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock 
https://bugs.webkit.org/show_bug.cgi?id=86045
Summary [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
Adam Barth
Reported 2012-05-09 17:19:32 PDT
[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
Attachments
Patch (1.56 KB, patch)
2012-05-09 17:20 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-05-09 17:20:53 PDT
Created attachment 141062 [details] Patch
Adam Barth
Comment 2 2012-05-09 17:21:18 PDT
Another possibility is to add ENABLE macros to these files.
Eric Seidel (no email)
Comment 3 2012-05-09 17:22:20 PDT
Comment on attachment 141062 [details] Patch OK.
WebKit Review Bot
Comment 4 2012-05-09 18:00:42 PDT
Comment on attachment 141062 [details] Patch Clearing flags on attachment: 141062 Committed r116590: <http://trac.webkit.org/changeset/116590>
WebKit Review Bot
Comment 5 2012-05-09 18:00:47 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 6 2012-05-09 22:50:06 PDT
(In reply to comment #4) > (From update of attachment 141062 [details]) > Clearing flags on attachment: 141062 > > Committed r116590: <http://trac.webkit.org/changeset/116590> This made a build error on Android. I reverted the change. /usr/local/google/b/webkit-slave/chromium-linux-android/build/Source/WebKit/chromium/android-ndk-r7b/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: out/Release/obj.target/DumpRenderTree/Tools/DumpRenderTree/chromium/WebViewHost.o: in function WebViewHost::userMediaClientMock():Tools/DumpRenderTree/chromium/WebViewHost.cpp:728: error: undefined reference to 'WebKit::WebUserMediaClientMock::create()'
Adam Barth
Comment 7 2012-05-09 22:54:35 PDT
Thanks.
Adam Barth
Comment 8 2012-05-09 22:55:25 PDT
We're going to need to do these GYP changes later.
Note You need to log in before you can comment on or make changes to this bug.