Created attachment 140200 [details] Patch

Comment on attachment 140200 [details] Patch Attachment 140200 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12627111

Comment on attachment 140200 [details] Patch Attachment 140200 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12627112

Comment on attachment 140200 [details] Patch Attachment 140200 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12626114

Comment on attachment 140200 [details] Patch Attachment 140200 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12631144

Comment on attachment 140200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140200&action=review > Source/WebCore/bindings/js/ScriptController.cpp:332 > + return 0; Please file a bug and insert FIXME here. > Source/WebCore/bindings/v8/V8Proxy.cpp:637 > + return v8::Local<v8::Context>(); Can this happen? > Source/WebCore/bindings/v8/V8Proxy.h:255 > +#if ENABLE(INSPECTOR) Chrome(i)um does not compile without inspector. > Source/WebCore/inspector/CodeGeneratorInspector.py:188 > + skip_js_bind_domains = set(["DOMDebugger"]) What does it mean? > Source/WebCore/inspector/Inspector.json:432 > + "id": "IsolatedContext", EvaluationContext ? > Source/WebCore/inspector/Inspector.json:436 > + { "name": "id", "type": "integer", "description": "World id. It can be used to specify in which world script evaluation should be performed." }, I would rename it to "contextId" or type "ContextId". > Source/WebCore/inspector/Inspector.json:438 > + { "name": "frameId", "$ref": "Network.FrameId", "description": "Id of the owning frame." } reorder by importance? > Source/WebCore/inspector/Inspector.json:453 > + { "name": "contextId", "type": "integer", "optional": true, "description": "Specifies in which isolated context to perform evaluation. Each content script lives in an isolated context and this parameter may be used to specify on of those contexts. If the parameter is omitted or 0 the evaluation will be performed in the context of the inspected page.", "hidden": true }, I think it is better to combine the frame and context id into the single contextId and stick to that term in runtime / debugger.

(In reply to comment #6) > (From update of attachment 140200 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140200&action=review > > > Source/WebCore/bindings/js/ScriptController.cpp:332 > > + return 0; > > Please file a bug and insert FIXME here. > Filed https://bugs.webkit.org/show_bug.cgi?id=85709 > > Source/WebCore/bindings/v8/V8Proxy.cpp:637 > > + return v8::Local<v8::Context>(); > > Can this happen? > Removed that code. > > Source/WebCore/bindings/v8/V8Proxy.h:255 > > +#if ENABLE(INSPECTOR) > > Chrome(i)um does not compile without inspector. > Removed. > > Source/WebCore/inspector/CodeGeneratorInspector.py:188 > > + skip_js_bind_domains = set(["DOMDebugger"]) > > What does it mean? > It is a list of domains for which we don't generate register<Domain>Dispatcher() methods in the front-end. > > Source/WebCore/inspector/Inspector.json:432 > > + "id": "IsolatedContext", > > EvaluationContext ? > Renamed to ExecutionContextDescription, introduced ExecutionContextId. > > Source/WebCore/inspector/Inspector.json:436 > > + { "name": "id", "type": "integer", "description": "World id. It can be used to specify in which world script evaluation should be performed." }, > > I would rename it to "contextId" or type "ContextId". > Done ExecutionContextId. > > Source/WebCore/inspector/Inspector.json:438 > > + { "name": "frameId", "$ref": "Network.FrameId", "description": "Id of the owning frame." } > > reorder by importance? > Done. > > Source/WebCore/inspector/Inspector.json:453 > > + { "name": "contextId", "type": "integer", "optional": true, "description": "Specifies in which isolated context to perform evaluation. Each content script lives in an isolated context and this parameter may be used to specify on of those contexts. If the parameter is omitted or 0 the evaluation will be performed in the context of the inspected page.", "hidden": true }, > > I think it is better to combine the frame and context id into the single contextId and stick to that term in runtime / debugger. Done.

Created attachment 140401 [details] Patch

Committed r116744: <http://trac.webkit.org/changeset/116744>