RESOLVED FIXED 85041
[EFL][WK2] Compile webkit1 and webkit2 by default. 
https://bugs.webkit.org/show_bug.cgi?id=85041
Summary [EFL][WK2] Compile webkit1 and webkit2 by default.
Mariusz Grzegorczyk
Reported 2012-04-27 02:32:23 PDT
There is no option to build EFL's webkit2 from Tools/Scripts/build-webkit script.
Attachments
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script (1.30 KB, patch)
2012-04-27 02:35 PDT, Mariusz Grzegorczyk 		no flags
DetailsFormatted DiffDiff
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script (1.30 KB, patch)
2012-05-31 11:04 PDT, Mariusz Grzegorczyk 		no flags
DetailsFormatted DiffDiff
Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script (1.32 KB, patch)
2012-06-05 04:54 PDT, Mariusz Grzegorczyk 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mariusz Grzegorczyk
Comment 1 2012-04-27 02:35:32 PDT
Created attachment 139156 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script
Gyuyoung Kim
Comment 2 2012-05-22 22:14:35 PDT
Comment on attachment 139156 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Basically, looks good to me. However, can efl webkit2 be built on trunk ?
Mariusz Grzegorczyk
Comment 3 2012-05-23 01:02:20 PDT
(In reply to comment #2) > (From update of attachment 139156 [details]) > Basically, looks good to me. However, can efl webkit2 be built on trunk ? If all related patches will be merged, webkit2 can be built on trunk like gtk port.
Dominik Röttsches (drott)
Comment 4 2012-05-28 07:43:14 PDT
Mariusz, I am seeing the same issue as the EWS on my machine: "-- Configuring done CMake Error in Source/WebKit2/CMakeLists.txt: Cannot find source file "WebCoreArgumentCodersEfl.cpp". Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx" I am looking into it.
Ryuan Choi
Comment 5 2012-05-31 05:40:10 PDT
mariusz, Could you rebase the patch? I think that WebKit/Efl will be compiled in ews now.
Gyuyoung Kim
Comment 6 2012-05-31 05:57:34 PDT
I think we need to support --only-webkit and --no-webkit2 options for EFL port. For example, GTK port supports this option as below, - http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L365 If possible, could you support this option as well?
Mariusz Grzegorczyk
Comment 7 2012-05-31 11:03:42 PDT
(In reply to comment #6) > I think we need to support --only-webkit and --no-webkit2 options for EFL port. > > For example, GTK port supports this option as below, > - http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L365 > > If possible, could you support this option as well? --no-webkit2 option is used as $noWebKit2 variable, and --only-webkit is as I see platform independent
Mariusz Grzegorczyk
Comment 8 2012-05-31 11:04:57 PDT
Created attachment 145116 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Rebased.
Ryuan Choi
Comment 9 2012-05-31 16:30:22 PDT
(In reply to comment #8) > Created an attachment (id=145116) [details] > Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script > > Rebased. Thank you. informal r+ on my side.
Gyuyoung Kim
Comment 10 2012-05-31 17:31:36 PDT
Looks good to me. Thanks.
Raphael Kubo da Costa (:rakuco)
Comment 11 2012-06-01 07:17:16 PDT
Comment on attachment 145116 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script View in context: https://bugs.webkit.org/attachment.cgi?id=145116&action=review It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt. > Tools/Scripts/build-webkit:677 > + $cmakeArgs .= ($cmakeArgs ? " " : "") . "-DENABLE_WEBKIT=On"; > + $cmakeArgs .= " -DENABLE_WEBKIT2=On" if !$noWebKit2; Style nit: we generally use "ON" instead of "On".
Mariusz Grzegorczyk
Comment 12 2012-06-04 04:37:58 PDT
> It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt. Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra?
Gyuyoung Kim
Comment 13 2012-06-04 18:15:13 PDT
(In reply to comment #12) EWS is compiling webkit using "Tools/Scripts/build-webkit --efl". If there is no problems when you build WebKit with your patches, I think EWS also won't have problems.(In reply to comment #12) > > It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt. > > Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra? If the feature is not defined in WebKitFeatures, UNINITIALIZED is added to CMakeCache.txt. But, I think we don't need to add ENABLE_WEBKIT2 to WebKitFeatures yet. http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake#L14 I ran webkit1 and webkit2 with this patch. Then, I could get both libewebkit2.so and libewebkit.so. It seems to me there is no problem. Kubo, do you think ENABLE_WEBKIT2 is off yet ? Mariusz, as kubo said, you need to use uppercase for "On".
Mariusz Grzegorczyk
Comment 14 2012-06-05 04:54:39 PDT
Created attachment 145759 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Rebased, make changes pointed by Raphael
Grzegorz Czajkowski
Comment 15 2012-06-06 05:30:22 PDT
LGTM.
Gyuyoung Kim
Comment 16 2012-06-06 19:45:13 PDT
Comment on attachment 145759 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Looks good to me.
Ryuan Choi
Comment 17 2012-06-06 19:46:16 PDT
LGTM too.
WebKit Review Bot
Comment 18 2012-06-06 21:26:40 PDT
Comment on attachment 145759 [details] Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Clearing flags on attachment: 145759 Committed r119678: <http://trac.webkit.org/changeset/119678>
WebKit Review Bot
Comment 19 2012-06-06 21:26:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.