RESOLVED FIXED 84940
Chromium Windows Perf bot timeouts due to no output 
https://bugs.webkit.org/show_bug.cgi?id=84940
Summary Chromium Windows Perf bot timeouts due to no output
Ryosuke Niwa
Reported 2012-04-26 03:34:55 PDT
Chromium Windows Perf bots timeout due to not output
Attachments
Fixes the bug (32.24 KB, patch)
2012-04-26 03:38 PDT, Ryosuke Niwa 		dpranke: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-04-26 03:38:02 PDT
Created attachment 138966 [details] Fixes the bug
Early Warning System Bot
Comment 2 2012-04-26 03:46:28 PDT
Comment on attachment 138966 [details] Fixes the bug Attachment 138966 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12490806
Ryosuke Niwa
Comment 3 2012-04-26 03:48:11 PDT
(In reply to comment #2) > (From update of attachment 138966 [details]) > Attachment 138966 [details] did not pass qt-wk2-ews (qt): > Output: http://queues.webkit.org/results/12490806 It seems like Qt EWS is broken :(
Dirk Pranke
Comment 4 2012-04-26 16:30:00 PDT
Comment on attachment 138966 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=138966&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:275 > + '', ''])) nit: you can use python's automatic string concatenation here and not have to do the join, e.g.: self.assertEquals(logs, ('Running (1 of 2)\n' 'RESULT\n' 'median\n') and so forth. That style is much more common in our code for these multi-line string constants.
Ryosuke Niwa
Comment 5 2012-04-27 12:20:20 PDT
Committed r115466: <http://trac.webkit.org/changeset/115466>
Note You need to log in before you can comment on or make changes to this bug.