WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84853
Share code used to animate discrete types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84853
Summary
Share code used to animate discrete types between all animators
Nikolas Zimmermann
Reported
2012-04-25 06:05:02 PDT
Share code used to animate discrete types between all animators.
Attachments
Patch
(24.51 KB, patch)
2012-04-25 06:08 PDT
,
Nikolas Zimmermann
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2012-04-25 06:08:26 PDT
Created
attachment 138797
[details]
Patch
Andreas Kling
Comment 2
2012-04-26 00:44:57 PDT
Comment on
attachment 138797
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=138797&action=review
Great cleanup, and you're adding a test. What's not to love? r=me
> Source/WebCore/svg/SVGAnimateElement.h:52 > + virtual bool isAdditive() const;
We should add OVERRIDE here.
Nikolas Zimmermann
Comment 3
2012-04-26 00:52:04 PDT
Committed
r115296
: <
http://trac.webkit.org/changeset/115296
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug