Created attachment 138516 [details] Patch

Comment on attachment 138516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review > Source/WebCore/ChangeLog:12 > + No new tests. This behavior is not testable by DRT yet. Just an out-of-curiosity question: What makes it difficult to test calendar picker behavior in DRT? > Source/WebCore/html/BaseDateAndTimeInputType.cpp:144 > + if (shouldHaveSpinButton()) > + handleWheelEventForSpinButton(event); Is this needed to this patch?

Comment on attachment 138516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review >> Source/WebCore/ChangeLog:12 >> + No new tests. This behavior is not testable by DRT yet. > > Just an out-of-curiosity question: What makes it difficult to test calendar picker behavior in DRT? Chromium DRT can't see objects not drawn in FrameViews because it has only one off-screen buffer and the main FrameView is drawn on it. >> Source/WebCore/html/BaseDateAndTimeInputType.cpp:144 >> + handleWheelEventForSpinButton(event); > > Is this needed to this patch? This change is for consistency. No spin button, no event handling for spin button. I should have mentioned this behavior change in ChangeLog.

Comment on attachment 138516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review >>> Source/WebCore/html/BaseDateAndTimeInputType.cpp:144 >>> + handleWheelEventForSpinButton(event); >> >> Is this needed to this patch? > > This change is for consistency. No spin button, no event handling for spin button. > > I should have mentioned this behavior change in ChangeLog. Thanks for the clarification. Let's describe it in ChangeLog.

Comment on attachment 138516 [details] Patch Attachment 138516 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12518296 New failing tests: fast/forms/date/date-stepup-stepdown-from-renderer.html

Created attachment 138612 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

(In reply to comment #4) > > I should have mentioned this behavior change in ChangeLog. > > Thanks for the clarification. Let's describe it in ChangeLog. I have updated ChangeLog and date-stepup-stepdown-from-renderer.html, and I'm landing the patch.

Committed r115155: <http://trac.webkit.org/changeset/115155>