WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
82808
Clean up MediaQueryEvaluator construction in CSSStyleSelector (and remove out of date comments)
https://bugs.webkit.org/show_bug.cgi?id=82808
Summary
Clean up MediaQueryEvaluator construction in CSSStyleSelector (and remove out...
Eric Seidel (no email)
Reported
2012-03-30 17:24:13 PDT
Clean up MediaQueryEvaluator construction in CSSStyleSelector (and remove out of date comments)
Attachments
Patch
(2.62 KB, patch)
2012-03-30 17:24 PDT
,
Eric Seidel (no email)
abarth
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ec2-cq-02
(7.03 MB, application/zip)
2012-03-30 21:06 PDT
,
WebKit Review Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2012-03-30 17:24:39 PDT
Created
attachment 134917
[details]
Patch
Adam Barth
Comment 2
2012-03-30 17:36:22 PDT
Comment on
attachment 134917
[details]
Patch I guess this depends on whether styleForElement needs m_medium, but it seems like if it does, it's going to get the wrong one with the old code...
Eric Seidel (no email)
Comment 3
2012-03-30 20:26:31 PDT
Comment on
attachment 134917
[details]
Patch Should apply now.
WebKit Review Bot
Comment 4
2012-03-30 21:06:41 PDT
Comment on
attachment 134917
[details]
Patch Rejecting
attachment 134917
[details]
from commit-queue. New failing tests: http/tests/appcache/deferred-events-delete-while-raising-timer.html animations/3d/transform-origin-vs-functions.html accessibility/aria-checkbox-checked.html http/tests/appcache/access-via-redirect.php animations/animation-css-rule-types.html animations/3d/matrix-transform-type-animation.html animations/animation-border-overflow.html http/tests/appcache/cyrillic-uri.html animations/animation-controller-drt-api.html http/tests/appcache/credential-url.html http/tests/appcache/crash-when-navigating-away-then-back.html accessibility/anonymous-render-block-in-continuation-causes-crash.html accessibility/adjacent-continuations-cause-assertion-failure.html animations/additive-transform-animations.html animations/3d/change-transform-in-end-event.html animations/3d/replace-filling-transform.html animations/3d/state-at-end-event-transform.html accessibility/anchor-linked-anonymous-block-crash.html accessibility/aria-checkbox-sends-notification.html animations/animation-add-events-in-handler.html Full output:
http://queues.webkit.org/results/12262579
WebKit Review Bot
Comment 5
2012-03-30 21:06:46 PDT
Created
attachment 134940
[details]
Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug