WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82015
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=82015
Summary
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Par...
Adam Barth
Reported
2012-03-22 22:35:29 PDT
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 1)
Attachments
Patch
(24.96 KB, patch)
2012-03-22 22:40 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-03-22 22:40:09 PDT
Created
attachment 133432
[details]
Patch
Kentaro Hara
Comment 2
2012-03-22 22:49:32 PDT
Comment on
attachment 133432
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=133432&action=review
> Source/WebCore/notifications/DOMWindowNotifications.h:32 > +#include "DOMWindowProperty.h"
Nit: This wouldn't be necessary in this patch, but it is OK. You'll add it in the next patch.
Adam Barth
Comment 3
2012-03-22 22:50:06 PDT
Yeah. :)
WebKit Review Bot
Comment 4
2012-03-22 23:29:33 PDT
Comment on
attachment 133432
[details]
Patch Clearing flags on attachment: 133432 Committed
r111832
: <
http://trac.webkit.org/changeset/111832
>
WebKit Review Bot
Comment 5
2012-03-22 23:29:38 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug