RESOLVED FIXED 80881
Implement proper sub-pixel support in RenderFileUploadControl 
https://bugs.webkit.org/show_bug.cgi?id=80881
Summary Implement proper sub-pixel support in RenderFileUploadControl
Levi Weintraub
Reported 2012-03-12 13:49:47 PDT
We currently do some improper truncating and promoting of LayoutUnits to floats without pixel snapping in RenderFileUploadControl.
Attachments
Patch (3.80 KB, patch)
2012-03-12 14:16 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2012-03-12 14:27 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-12 14:16:07 PDT
Created attachment 131406 [details] Patch
Emil A Eklund
Comment 2 2012-03-12 14:21:31 PDT
Comment on attachment 131406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131406&action=review > Source/WebCore/rendering/RenderFileUploadControl.cpp:107 > + IntRect clipRect = pixelSnappedIntRect(LayoutRect(paintOffset.x() + borderLeft(), paintOffset.y() + borderTop(), Isn't there a pixelSnappedIntRect implementation that takes x, y, w, h? Seems better than creating a LayoutRect and then immediately snapping it. > Source/WebCore/rendering/RenderFileUploadControl.cpp:157 > + input->icon()->paint(paintInfo.context, IntRect(roundedIntPoint(LayoutPoint(iconX, iconY)), IntSize(iconWidth, iconHeight))); IntRect(iconX.round(), iconY.round(), iconWidth, iconHeight) seems easier.
Levi Weintraub
Comment 3 2012-03-12 14:27:50 PDT
Created attachment 131413 [details] Patch
Emil A Eklund
Comment 4 2012-03-12 14:30:50 PDT
Looks good, thanks!
Levi Weintraub
Comment 5 2012-03-14 10:38:28 PDT
Any takers on a review?
Dimitri Glazkov (Google)
Comment 6 2012-03-14 13:54:31 PDT
Comment on attachment 131413 [details] Patch ok
Levi Weintraub
Comment 7 2012-03-14 14:14:18 PDT
Comment on attachment 131413 [details] Patch Thanks for the review, Mr. Glazkov :)
WebKit Review Bot
Comment 8 2012-03-14 15:02:17 PDT
Comment on attachment 131413 [details] Patch Clearing flags on attachment: 131413 Committed r110761: <http://trac.webkit.org/changeset/110761>
WebKit Review Bot
Comment 9 2012-03-14 15:02:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.