RESOLVED FIXED 80488
Rename NotificationPresenter to NotificationClient 
https://bugs.webkit.org/show_bug.cgi?id=80488
Summary Rename NotificationPresenter to NotificationClient
Jon Lee
Reported 2012-03-06 21:53:59 PST
The name NotificationPresenter doesn't match the naming pattern for other features like geolocation. Should rename as NotificationClient. <rdar://problem/10965558>
Attachments
WIP (60.96 KB, patch)
2012-03-09 13:51 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (61.32 KB, patch)
2012-03-09 15:12 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
WIP (62.04 KB, patch)
2012-03-09 22:07 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (73.08 KB, patch)
2012-03-09 23:42 PST, Jon Lee 		haraken: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2012-03-09 13:51:42 PST
Created attachment 131098 [details] WIP
WebKit Review Bot
Comment 2 2012-03-09 13:57:12 PST
Attachment 131098 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.cpp:54: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationClient.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-03-09 14:41:15 PST
Comment on attachment 131098 [details] WIP Attachment 131098 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11915707
Early Warning System Bot
Comment 4 2012-03-09 15:01:05 PST
Comment on attachment 131098 [details] WIP Attachment 131098 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11911767
Jon Lee
Comment 5 2012-03-09 15:12:01 PST
Created attachment 131121 [details] Patch
WebKit Review Bot
Comment 6 2012-03-09 15:13:59 PST
Attachment 131121 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.cpp:54: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationClient.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jon Lee
Comment 7 2012-03-09 22:07:33 PST
Created attachment 131153 [details] WIP
WebKit Review Bot
Comment 8 2012-03-09 22:10:23 PST
Attachment 131153 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/GNUmakefile.list.am', u'Sou..." exit_code: 1 Source/WebCore/notifications/NotificationCenter.cpp:54: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.h:55: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/notifications/NotificationClient.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jon Lee
Comment 9 2012-03-09 23:42:21 PST
Created attachment 131160 [details] Patch
Kentaro Hara
Comment 10 2012-03-10 03:14:28 PST
Comment on attachment 131160 [details] Patch Looks OK. This patch will conflict with my patch (https://bugs.webkit.org/show_bug.cgi?id=79636). Let's commit this patch first.
Jon Lee
Comment 11 2012-03-10 10:43:20 PST
Committed r110381: http://trac.webkit.org/changeset/110381
Note You need to log in before you can comment on or make changes to this bug.