RESOLVED FIXED 79874
[BlackBerry] Upstream LayerRenderer.{h, cpp} 
https://bugs.webkit.org/show_bug.cgi?id=79874
Summary [BlackBerry] Upstream LayerRenderer.{h, cpp}
Robin Cao
Reported 2012-02-28 22:35:29 PST
LayerRenderer is the class that takes care of drawing of composited layers using GLES2.
Attachments
patch (56.58 KB, patch)
2012-03-01 06:24 PST, Robin Cao 		no flags
DetailsFormatted DiffDiff
patch-for-landing (56.87 KB, patch)
2012-03-06 04:48 PST, Robin Cao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-02-29 08:48:18 PST
Note that we currently have this warning: Source/WebCore/platform/graphics/blackberry/LayerRenderer.h: In constructor 'WebCore::LayerRenderer::LayerRenderer(BlackBerry::Platform::Graphics::GLES2Context*)': Source/WebCore/platform/graphics/blackberry/LayerRenderer.h:191: warning: 'WebCore::LayerRenderer::m_needsCommit' will be initialized after ource/WebCore/platform/graphics/blackberry/LayerRenderer.h:150: warning: 'unsigned int WebCore::LayerRenderer::m_colorProgramObject' Would be great to fix this in the upstreaming.
Robin Cao
Comment 2 2012-03-01 06:24:32 PST
Created attachment 129696 [details] patch
Antonio Gomes
Comment 3 2012-03-03 18:14:02 PST
Comment on attachment 129696 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=129696&action=review Looks good to me, but we might need another round (see comment below) > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:51 > + > +#define DEBUG_VIDEO_CLIPPING 0 drop blank line > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:340 > +bool LayerRenderer::useSurface(RenderSurface* surface) I think Niko asked you to rename RenderSurface to something else, right? So this will need another round :(
Robin Cao
Comment 4 2012-03-06 04:48:35 PST
Created attachment 130356 [details] patch-for-landing
Robin Cao
Comment 5 2012-03-06 04:51:36 PST
The blank line is removed, and all references to RenderSurface are updated in the revised patch.
Antonio Gomes
Comment 6 2012-03-06 04:58:56 PST
Comment on attachment 130356 [details] patch-for-landing View in context: https://bugs.webkit.org/attachment.cgi?id=130356&action=review > Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:505 > +{ > + > + // The contract for LayerCompositingThread::setLayerRenderer is it must be set if the layer has been rendered. :o
WebKit Review Bot
Comment 7 2012-03-06 05:15:22 PST
Comment on attachment 130356 [details] patch-for-landing Clearing flags on attachment: 130356 Committed r109908: <http://trac.webkit.org/changeset/109908>
WebKit Review Bot
Comment 8 2012-03-06 05:15:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.